From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread Date: Wed, 25 Apr 2018 10:14:18 +0100 Message-ID: References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-9-git-send-email-arnon@qwilt.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Arnon Warshavsky , thomas@monjalon.net, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8ED792C19 for ; Wed, 25 Apr 2018 11:14:22 +0200 (CEST) In-Reply-To: <1524608213-2080-9-git-send-email-arnon@qwilt.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 24-Apr-18 11:16 PM, Arnon Warshavsky wrote: > replace panic calls with log and return value. > Thread function removes the noreturn attribute. > > Signed-off-by: Arnon Warshavsky > --- Just a general comment - i'm not too familiar with this code, but it looks like all of these failures will only happen on thread init. Can we make sure it starts? You can use similar approach to Olivier's (recently merged) thread affinity patches, with pthread barriers etc. to ensure the thread has initialized properly, pthread_cancel() it if it didn't, and return -1 on thread init. -- Thanks, Anatoly