From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 22/38] net/dpaa: add NXP DPAA PMD driver
	skeleton
Date: Sun, 2 Jul 2017 12:17:28 +0530
Message-ID: <f27ebe1f-d83d-a78f-87d0-efceb500e9bf@nxp.com>
References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com>
 <1497591668-3320-23-git-send-email-shreyansh.jain@nxp.com>
 <39ded621-6575-fdbe-8d7c-9f1f5dd6be6e@intel.com>
 <589e8109-196c-daef-855a-6239bb7e0f7e@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0064.outbound.protection.outlook.com [104.47.32.64])
 by dpdk.org (Postfix) with ESMTP id EE7202B99
 for <dev@dpdk.org>; Sun,  2 Jul 2017 08:38:25 +0200 (CEST)
In-Reply-To: <589e8109-196c-daef-855a-6239bb7e0f7e@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thursday 29 June 2017 07:59 PM, Shreyansh Jain wrote:
> Hello Ferruh,
> 
[...]
> 
>>
>>> +
>>> +    if (rte_eal_process_type() == RTE_PROC_PRIMARY)
>>> +        rte_free(eth_dev->data->dev_private);
>>> +
>>
>> no pmd uninit() ?

Just to clarify, were you asking about uninit of the driver?

There is no such call from within normal flow - that is probably left to the application to perform. (rte_dpaa_driver_unregister)
I just cross checked, this is not being done even for the PCI functions (rte_pci_unregister) - probably because we never see a case (for sample applications) where driver is unregistered.

Am I missing something here?

> 
> I will fix this. There is an internal commit that we had very
> recently (a miss in previous series).

There was some device/queue cleanup which was missing which I have added and will push in the next version. I mixed that up with 'PMD uninit' comment when I was replying to your previous email.

> 
>>

-
Shreyansh