From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [PATCH v10 2/4] examples/l3fwd-power: simple app update for new API Date: Tue, 2 Oct 2018 15:23:33 +0100 Message-ID: References: <1538146714-30973-1-git-send-email-liang.j.ma@intel.com> <1538488107-7181-1-git-send-email-liang.j.ma@intel.com> <1538488107-7181-2-git-send-email-liang.j.ma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, lei.a.yao@intel.com, ktraynor@redhat.com, marko.kovacevic@intel.com To: Liang Ma Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 61AEE5F16 for ; Tue, 2 Oct 2018 16:23:37 +0200 (CEST) In-Reply-To: <1538488107-7181-2-git-send-email-liang.j.ma@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/10/2018 2:48 PM, Liang Ma wrote: > Add the support for new traffic pattern aware power control > power management API. > > Example: > ./l3fwd-power -l xxx -n 4 -w 0000:xx:00.0 -w 0000:xx:00.1 -- -p 0x3 > -P --config="(0,0,xx),(1,0,xx)" --empty-poll="0,0,0" -l 14 -m 9 -h 1 > > Please Reference l3fwd-power document for full parameter usage > > The option "l", "m", "h" are used to set the power index for > LOW, MED, HIGH power state. Only is useful after enable empty-poll > > --empty-poll="training_flag, med_threshold, high_threshold" > > The option training_flag is used to enable/disable training mode. > > The option med_threshold is used to indicate the empty poll threshold > of modest state which is customized by user. > > The option high_threshold is used to indicate the empty poll threshold > of busy state which is customized by user. > > Above three option default value is all 0. > > Once enable empty-poll. System will apply the default parameter if no > other command line options are provided. > > If training mode is enabled, the user should ensure that no traffic > is allowed to pass through the system. When training phase complete, > the application transfer to normal operation > > System will start running with the modest power mode. > If the traffic goes above 70%, then system will move to High power state. > If the traffic drops below 30%, the system will fallback to the modest > power state. > > Example code use master thread to monitoring worker thread busyness. > The default timer resolution is 10ms. > > ChangeLog: > v2 fix some coding style issues > v3 rename the API. > v6 re-work the API. > v7 no change. > v8 disable training as default option. > v10 update due to review comments. > > Signed-off-by: Liang Ma > > Reviewed-by: Lei Yao > --- Acked-by: David Hunt