From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v3 2/3] eal: add synchronous multi-process communication Date: Thu, 25 Jan 2018 12:19:23 +0000 Message-ID: References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-3-git-send-email-jianfeng.tan@intel.com> <93ea032e-e2da-f087-567a-2397fad7ff02@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F02EE2BE5 for ; Thu, 25 Jan 2018 13:19:25 +0100 (CET) In-Reply-To: <93ea032e-e2da-f087-567a-2397fad7ff02@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > See above: it would be much more useful to return number of replies > received, rather than number of messages sent, as that's the number we > are most interested in. Otherwise, if we e.g. sent 5 messages but > received 1 reply, you're essentially not telling the user how far can he > index the reply pointer. Apologies, just noticed that rte_mp_reply has nb_messages in it. So if we are getting number of replies along with reply, this API should too switch to 0/-1 on success/failure respectively, as the number of sent messages also becomes meaningless to the user. -- Thanks, Anatoly