From: Marat Khalili <marat.khalili@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>,
Su Sai <spiderdetective.ss@gmail.com>
Subject: RE: [v3] net/cksum: compute raw cksum for several segments
Date: Fri, 20 Feb 2026 18:17:32 +0000 [thread overview]
Message-ID: <f33de0e613c44887a26fe8bf90022d2d@huawei.com> (raw)
In-Reply-To: <33965644.t2Qszz9eOc@thomas>
> I didn't take time to review the full explanation and code.
>
> Please could you review?
>
> https://inbox.dpdk.org/dev/CAFQeoKi8W8WAYUY1OuSn+qMgG1c2V7PjLjEH608m894TpLOVvw@mail.gmail.com/
>
I can suggest my condition to get a wrong checksum, which does not go into the details of how it was observed in the wild:
Function rte_raw_cksum_mbuf may produce incorrect result when multiple segments are present in the checksummed range, and some of them have odd checksummed length. More precisely, if any segment except the last one begins at an odd offset from the start, and arithmetic sum of its 16-bit words overflows, the part that has overflown will be lost. Cases when there is only one segment, or all of the segment sizes and checksum offsets are even, are not affected.
next prev parent reply other threads:[~2026-02-20 18:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 9:55 [PATCH] net/cksum: compute raw cksum for several segments 苏赛
2025-07-31 10:51 ` Marat Khalili
2025-07-31 11:03 ` Marat Khalili
2025-07-31 11:31 ` [External] " Su Sai
2025-07-31 11:43 ` Marat Khalili
2025-07-31 11:46 ` Marat Khalili
2025-07-31 12:22 ` zhoumin
2025-08-01 7:26 ` Su Sai
2025-08-01 15:28 ` [v2] " Su Sai
2025-08-01 16:39 ` Marat Khalili
2025-08-02 11:08 ` [v3] " Su Sai
2025-08-03 16:08 ` Stephen Hemminger
2025-08-04 3:54 ` Su Sai
2025-08-05 8:55 ` Marat Khalili
2026-02-20 15:49 ` Marat Khalili
2026-02-20 17:23 ` Thomas Monjalon
2026-02-20 18:17 ` Marat Khalili [this message]
2026-02-20 18:35 ` Marat Khalili
2026-02-27 6:36 ` su sai
2026-02-27 7:31 ` su sai
2026-03-06 15:17 ` Marat Khalili
2025-08-11 14:42 ` Thomas Monjalon
2025-08-12 3:03 ` su sai
2026-02-20 17:49 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f33de0e613c44887a26fe8bf90022d2d@huawei.com \
--to=marat.khalili@huawei.com \
--cc=dev@dpdk.org \
--cc=spiderdetective.ss@gmail.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox