From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 06/12] app/testpmd: fix checksum stats in csum engine Date: Tue, 11 Oct 2016 15:46:17 +0200 Message-ID: References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-7-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: konstantin.ananyev@intel.com, sugesh.chandran@intel.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com, adrien.mazarguil@6wind.com, stephen@networkplumber.org, dprovan@bivio.net, xiao.w.wang@intel.com To: Olivier Matz , dev@dpdk.org, yuanhan.liu@linux.intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2DDB92BA6 for ; Tue, 11 Oct 2016 15:46:25 +0200 (CEST) In-Reply-To: <1475485223-30566-7-git-send-email-olivier.matz@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/03/2016 11:00 AM, Olivier Matz wrote: > --- > app/test-pmd/csumonly.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index d5eb260..8c88ee8 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -679,8 +679,10 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > rx_ol_flags = m->ol_flags; > > /* Update the L3/L4 checksum error packet statistics */ > - rx_bad_ip_csum += ((rx_ol_flags & PKT_RX_IP_CKSUM_BAD) != 0); > - rx_bad_l4_csum += ((rx_ol_flags & PKT_RX_L4_CKSUM_BAD) != 0); > + if ((rx_ol_flags & PKT_RX_IP_CKSUM_MASK) == PKT_RX_IP_CKSUM_BAD) > + rx_bad_ip_csum += 1; > + if ((rx_ol_flags & PKT_RX_L4_CKSUM_MASK) == PKT_RX_L4_CKSUM_BAD) > + rx_bad_l4_csum += 1; > > /* step 1: dissect packet, parsing optional vlan, ip4/ip6, vxlan > * and inner headers */ > Reviewed-by: Maxime Coquelin Thanks, Maxime