From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH] net/virtio-user: add unsupported features
	mask
Date: Tue, 26 Jun 2018 10:08:21 +0200
Message-ID: <f3b8f182-3a9c-c790-94dd-e3e37882ad70@redhat.com>
References: <20180625131002.95629-1-yong.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: zhihong.wang@intel.com, dev@dpdk.org
To: Marvin Liu <yong.liu@intel.com>, tiwei.bie@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id D22495F28
 for <dev@dpdk.org>; Tue, 26 Jun 2018 10:08:24 +0200 (CEST)
In-Reply-To: <20180625131002.95629-1-yong.liu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 06/25/2018 03:10 PM, Marvin Liu wrote:
> This patch introduces unsupported features mask for virtio-user device.
> For virtio-user server mode, when reconnecting virtio-user will
> retrieve vhost devcie features as base and then unmask unsupported
s/devcie/device/
> features.

I am not sure to understand why you are doing it like this.

Shouldn't you just:
  1. Don't advertise features you don't want to support
  2. In server mode, save the negotiated features, and re-use it when
     reconnect happens?

Also, I find "unmask" a bit misleading, why not something like "unsupp"
or "unsupported"?

Thanks,
Maxime