From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [RFC 9/9] usertools/lib: add GRUB utility library for hugepage config Date: Tue, 26 Jun 2018 10:05:00 +0100 Message-ID: References: <02efa4a4e6fab105ae883a855ae1985afc208a31.1529940601.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, david.hunt@intel.com, mohammad.abdul.awal@intel.com To: Kevin Wilson Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6933F1B44F for ; Tue, 26 Jun 2018 11:05:04 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26-Jun-18 2:09 AM, Kevin Wilson wrote: > Hi, Anatoly, > > Thanks for these patches, good work. > Regarding "update-grub": IIRC, this is Ubuntu specific command (and > also used in Debian/Debian based flavors). > In Fedora (RedHat based) recent distros, you use grub2-mkconfig > instead (and there is no "update-grub", IIRC). > If this is true, I would consider adding a comment in the commit log > saying something like "it is for Ubuntu/Debian-based distros". > So maybe in the future someone will add the python code which detects > the OS (using lsb-release, etc) and, in case it is Fedora/RedHat > distro, the grub2-mkconfig util > will be invoked instead. > Regards, > KW > Hi Kevin, It wasn't intended to be Ubuntu-specific - that's just what i developed this patchset on :) Of course, if we get to a v1 stage, this will be properly implemented to work on all distributions supported by DPDK. Thanks for your feedback! -- Thanks, Anatoly