From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH] examples: ethtool: Link against
 librte_pmd_ixgbe if necessary
Date: Tue, 4 Apr 2017 12:12:16 +0100
Message-ID: <f4191fb8-a440-959d-ae78-7b314cad214e@intel.com>
References: <20170216161731.4590-1-mchandras@suse.de>
 <1762973.YT1Za91pN5@xps13> <2310633.U6SXsHI9VC@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Nirmoy Das <ndas@suse.de>,
 "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Markos Chandras <mchandras@suse.de>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 33343326B
 for <dev@dpdk.org>; Tue,  4 Apr 2017 13:12:19 +0200 (CEST)
In-Reply-To: <2310633.U6SXsHI9VC@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 04/04/2017 11:15, Thomas Monjalon wrote:
> Ping
[..]
>>> --- a/examples/ethtool/ethtool-app/Makefile
>>> +++ b/examples/ethtool/ethtool-app/Makefile
>>> +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
>>> +LDLIBS += -lrte_pmd_ixgbe
>>> +endif
>>
>> Please, could you confirm we can remove the same LDLIBS line from
>> examples/ethtool/lib/Makefile ?

Did a quick smoke test and looks like it needs to be in lib/Makefile as 
well, at least for shared builds on Fedora. Not sure why though..

[ ethtool]$ make
== lib
   LD librte_ethtool.so.1
rte_ethtool.o: In function `rte_ethtool_net_set_rx_mode':
rte_ethtool.c:(.text+0x667): undefined reference to 
`rte_pmd_ixgbe_set_vf_rxmode'
collect2: error: ld returned 1 exit status