From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 1/2] net/softnic: enable flow classification
	function
Date: Thu, 7 Dec 2017 13:02:38 -0800
Message-ID: <f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com>
References: <20171130200843.98621-1-jasvinder.singh@intel.com>
 <20171130200843.98621-2-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: cristian.dumitrescu@intel.com, Thomas Monjalon <thomas@monjalon.net>
To: Jasvinder Singh <jasvinder.singh@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 4611229CA
 for <dev@dpdk.org>; Thu,  7 Dec 2017 22:02:40 +0100 (CET)
In-Reply-To: <20171130200843.98621-2-jasvinder.singh@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/30/2017 12:08 PM, Jasvinder Singh wrote:
> Enables flow classification on softnic rx path so that proceding
> functions of the packet processing pipeline such as metering and
> policing could be implemented.
> 
> Example: Create "soft" port for "hard" port "0000:02:00.1",
> enable the Flow Classification (FC) feature with default
> settings:
>   --vdev 'net_softnic0,hard_name=0000:02:00.1,soft_fc=on'
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>

<...>

> +#define PMD_PARAM_SOFT_FC					"soft_fc"
> +#define PMD_PARAM_SOFT_FC_NB_RULES			"soft_fc_nb_rules"
> +#define PMD_PARAM_SOFT_FC_FLOW_KEY_SIZE		"soft_fc_flow_key_size"
> +#define PMD_PARAM_SOFT_FC_FLOW_KEY_OFFSET	"soft_fc_flow_key_offset"
> +#define PMD_PARAM_SOFT_FC_FLOW_KEY_MASK		"soft_fc_flow_key_mask"
> +
>  #define PMD_PARAM_HARD_NAME					"hard_name"
>  #define PMD_PARAM_HARD_TX_QUEUE_ID			"hard_tx_queue_id"

I wouldn't mention if you won't be already sending a new version but can you
please align them :)

<...>

> @@ -60,7 +60,9 @@ _LDLIBS-y += -L$(RTE_SDK_BIN)/lib
>  #
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY)  += -lrte_flow_classify
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PIPELINE)       += -lrte_pipeline
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)            += --whole-archive
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)          += -lrte_table
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)            += --no-whole-archive

I think it is better to move rte_table between whole-archive flags, but I
vaguely remember Thomas preferred this in the past, so adding him for comment.