From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415C4C433E2 for ; Thu, 17 Sep 2020 10:36:04 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A3912208DB for ; Thu, 17 Sep 2020 10:36:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3912208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C69D41D5BA; Thu, 17 Sep 2020 12:36:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7394E1D5B1; Thu, 17 Sep 2020 12:35:59 +0200 (CEST) IronPort-SDR: nBwAuGx46NWeRmaLwoHMTIA/Vd+9Ic5RjGa6Os4wbWEGvHx1Is6q2b5cGYyuT+wjR+kA4D7Ji8 rvynNIRdl4xw== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="157073470" X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="157073470" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 03:35:57 -0700 IronPort-SDR: hQljpKiPzSPJ47bUa+7grET0nvb1fW1JM23Z/WDKgj7ygao9S6YomJSHW3J04NC4JC6cv8t3pd qiyj3efERaPg== X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="483694277" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.206.43]) ([10.213.206.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 03:35:56 -0700 To: wangyunjian , dev@dpdk.org Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org References: <20200621090800.1AE521C00D@dpdk.org> <1599822484-19100-1-git-send-email-wangyunjian@huawei.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 17 Sep 2020 11:35:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1599822484-19100-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 RESEND] vfio: fix resource leak when mapping fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11-Sep-20 12:08 PM, wangyunjian wrote: > From: Yunjian Wang > > Currently, only the 'vfio_dev_fd' is closed in failure path, so > some resources are not released(such as 'vfio_group_fd'). The > rte_vfio_release_device() should be used to avoid this problem. > > Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly