From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH v2] examples/ethtool: fix bug in drvinfo
	callback
Date: Wed, 23 Nov 2016 09:00:47 +0800
Message-ID: <f5d536d4-fe53-5ff9-4f6f-add6f102c171@intel.com>
References: <1479462013-11562-1-git-send-email-qiming.yang@intel.com>
 <1479778884-26993-1-git-send-email-qiming.yang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Qiming Yang <qiming.yang@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 5810C47D2
 for <dev@dpdk.org>; Wed, 23 Nov 2016 02:00:49 +0100 (CET)
In-Reply-To: <1479778884-26993-1-git-send-email-qiming.yang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Not sure this is a problem in practice, as the same set if fields is 
updated each time...at least for now.

On 22/11/2016 09:41, Qiming Yang wrote:
> Function pcmd_drvinfo_callback uses struct info to get
> the ethtool information of each port. Struct info will
> store the information of previous port until this
> information be updated. This patch fixes this issue.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>

Acked-by: Remy Horton <remy.horton@intel.com>