From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC67C00A89 for ; Fri, 30 Oct 2020 21:20:37 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 95133221FA for ; Fri, 30 Oct 2020 21:20:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95133221FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12DE7ACAA; Fri, 30 Oct 2020 22:20:34 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 079C19B02 for ; Fri, 30 Oct 2020 22:20:32 +0100 (CET) IronPort-SDR: ZLm/hLw19ex8Kw2wvT6C/LgeyBu9LuWnJeg1gKCJCtYVYFEvrd4s+QWxwM8v2ac8pTCBl5+GR3 ybgLO2puBjsg== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="167884561" X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="167884561" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 14:20:30 -0700 IronPort-SDR: 8Kx8EffKWjIAjTd2f0dfw5wiyQjswXdA/xxw0C+GEBBpboLI6HbxmpMXizZ95RpZB1froaEDK5 FKZ+TuE/dRkA== X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="362561408" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 14:20:30 -0700 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Jie Zhou , Olivier Matz , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Ori Kam , Radu Nicolau , Akhil Goyal , Cristian Dumitrescu , Jasvinder Singh , Maxime Coquelin , Chenbo Xia , David Hunt References: <20200902183805.5421-1-dmitry.kozliuk@gmail.com> <20201030010126.17928-1-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: Date: Fri, 30 Oct 2020 14:20:29 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201030010126.17928-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3] cmdline: avoid name clash with Windows system types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29/2020 6:01 PM, Dmitry Kozlyuk wrote: > cmdline_numtype member names clash with Windows system identifiers. > Add RTE_ prefix to cmdline constants to avoid this and possible > future conflicts. > > Suggested-by: Ranjit Menon > Signed-off-by: Dmitry Kozlyuk > --- > > v3: change prefix from CMDLINE_ to RTE_ (Bruce Richardson) > > app/test-cmdline/commands.c | 2 +- > app/test-pmd/bpf_cmd.c | 8 +- > app/test-pmd/cmdline.c | 705 +++++++++--------- > app/test-pmd/cmdline_flow.c | 2 +- > app/test-pmd/cmdline_mtr.c | 89 +-- > app/test-pmd/cmdline_tm.c | 196 ++--- > app/test/test_cmdline_num.c | 48 +- > examples/ethtool/ethtool-app/ethapp.c | 19 +- > examples/ipsec-secgw/parser.c | 2 +- > examples/qos_sched/cmdline.c | 46 +- > examples/vdpa/main.c | 2 +- > .../guest_cli/vm_power_cli_guest.c | 2 +- > examples/vm_power_manager/vm_power_cli.c | 8 +- > lib/librte_cmdline/cmdline_parse_num.c | 65 +- > lib/librte_cmdline/cmdline_parse_num.h | 16 +- > 15 files changed, 618 insertions(+), 592 deletions(-) > Acked-by: Ranjit Menon