From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 0/8] mbuf: structure reorganization
Date: Wed, 5 Apr 2017 13:06:50 +0100
Message-ID: <f6eed066-a657-7608-d612-61f50a674713@intel.com>
References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com>
 <20170404162807.20157-1-olivier.matz@6wind.com> <2948467.vjfs1XSdfO@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org,
 konstantin.ananyev@intel.com, bruce.richardson@intel.com,
 mb@smartsharesystems.com, andrey.chilikin@intel.com, jblunck@infradead.org,
 arybchenko@solarflare.com, jerin.jacob@caviumnetworks.com
To: nelio.laranjeiro@6wind.com, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 68D1E29C7
 for <dev@dpdk.org>; Wed,  5 Apr 2017 14:06:54 +0200 (CEST)
In-Reply-To: <2948467.vjfs1XSdfO@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/5/2017 10:37 AM, Thomas Monjalon wrote:
> 2017-04-04 18:27, Olivier Matz:
>> Based on discussions done in [1] and in this thread, this patchset reorganizes
>> the mbuf.
>>
>> The main changes are:
>> - reorder structure to increase vector performance on some non-ia
>>   platforms.
>> - add a 64bits timestamp field in the 1st cache line. This timestamp
>>   is not normalized, i.e. no unit or time reference is enforced. A
>>   library may be added to do this job in the future.
>> - m->next, m->nb_segs, and m->refcnt are always initialized for mbufs
>>   in the pool, avoiding the need of setting m->next (located in the
>>   2nd cache line) in the Rx path for mono-segment packets.
>> - change port and nb_segs to 16 bits
>> - move seqn in the 2nd cache line
> 
> Applied, thanks for the long work

Hi Nelio, Adrien,

After this patch, mlx5 with debug enabled giving following build error
[1] with gcc, not really sure about reason of the error, can you please
check?

[1]
.../drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_rx_burst’:
.../drivers/net/mlx5/mlx5_rxtx.c:2082:17: error: ‘len’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
   DATA_LEN(seg) = len;