From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3 04/22] vhost: make notify ops per vhost driver Date: Wed, 29 Mar 2017 17:03:28 +0200 Message-ID: References: <1490253059-28112-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-5-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Harris James R , Liu Changpeng To: Yuanhan Liu , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C5153D14E for ; Wed, 29 Mar 2017 17:03:31 +0200 (CEST) In-Reply-To: <1490705142-893-5-git-send-email-yuanhan.liu@linux.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/28/2017 02:45 PM, Yuanhan Liu wrote: > Assume there is an application both support vhost-user net and > vhost-user scsi, the callback should be different. Making notify > ops per vhost driver allow application define different set of > callbacks for different driver. > > Signed-off-by: Yuanhan Liu > --- > > v2: - check the return value of callback_register and callback_get > - update release note > --- > doc/guides/prog_guide/vhost_lib.rst | 2 +- > doc/guides/rel_notes/release_17_05.rst | 3 +++ > drivers/net/vhost/rte_eth_vhost.c | 20 +++++++++++--------- > examples/tep_termination/main.c | 7 ++++++- > examples/vhost/main.c | 9 +++++++-- > lib/librte_vhost/rte_virtio_net.h | 3 ++- > lib/librte_vhost/socket.c | 32 ++++++++++++++++++++++++++++++++ > lib/librte_vhost/vhost.c | 16 +--------------- > lib/librte_vhost/vhost.h | 5 ++++- > lib/librte_vhost/vhost_user.c | 22 ++++++++++++++++------ > 10 files changed, 83 insertions(+), 36 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime