DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Wolfe <rnwolfe@google.com>
To: dev@dpdk.org, Junfeng Guo <junfeng.guo@intel.com>,
	 Joshua Washington <joshwash@google.com>
Cc: stable@dpdk.org, Harshitha Ramamurthy <hramamurthy@google.com>,
	 Rushil Gupta <rushilg@google.com>
Subject: [PATCH v2 1/3] net/gve: clear first freed slot in bulk mbuf free
Date: Tue, 17 Nov 2026 09:11:42 -0500	[thread overview]
Message-ID: <f7c7f72e86bb340ca272c2b507fbcb3206aeb8b4.1794908231.git.rnwolfe@google.com> (raw)
In-Reply-To: <cover.1794908231.git.rnwolfe@google.com>

In gve_free_bulk_mbuf(), the initial scan for the first segment ready
to return to its mempool calls rte_pktmbuf_prefree_seg(txep[s]) without
clearing txep[s]. Neither the early scan (including refcounted segments
where prefree returns NULL) nor the subsequent loop starting at s + 1
resets txep[s] to NULL, leaving stale mbuf pointers in sw_ring that
gve_release_txq_mbufs() frees a second time on queue stop or release.

Clear txep[s] immediately after rte_pktmbuf_prefree_seg(), matching the
cleanup loop for the remaining entries.

Fixes: a46583cf43c8 ("net/gve: support Rx/Tx")
Cc: stable@dpdk.org

Signed-off-by: Ryan Wolfe <rnwolfe@google.com>
---
 drivers/net/gve/gve_tx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c
index 279669165f..d344648d0f 100644
--- a/drivers/net/gve/gve_tx.c
+++ b/drivers/net/gve/gve_tx.c
@@ -19,6 +19,7 @@ gve_free_bulk_mbuf(struct rte_mbuf **txep, int num)
 	for (s = 0; s < num; s++) {
 		if (txep[s] != NULL) {
 			m = rte_pktmbuf_prefree_seg(txep[s]);
+			txep[s] = NULL;
 			if (m != NULL)
 				break;
 		}

  reply	other threads:[~2026-11-18  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 14:00 [PATCH] net/gve: fix GQI QPL jumbo Tx FIFO reclaim and doorbell Ryan Wolfe
2026-11-17 14:11 ` [PATCH v2 0/3] net/gve: fix GQI Tx cleanup and QPL FIFO reclaim Ryan Wolfe
2026-11-17 14:11   ` Ryan Wolfe [this message]
2026-11-17 14:11   ` [PATCH v2 2/3] net/gve: fix GQI RDA multi-seg descriptor length and clean Ryan Wolfe
2026-11-17 14:11   ` [PATCH v2 3/3] net/gve: fix GQI QPL jumbo Tx FIFO reclaim and doorbell Ryan Wolfe
2026-11-17 17:34 ` [PATCH] " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7c7f72e86bb340ca272c2b507fbcb3206aeb8b4.1794908231.git.rnwolfe@google.com \
    --to=rnwolfe@google.com \
    --cc=dev@dpdk.org \
    --cc=hramamurthy@google.com \
    --cc=joshwash@google.com \
    --cc=junfeng.guo@intel.com \
    --cc=rushilg@google.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox