From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: Re: [PATCH v5 2/2] ci: Introduce travis builds for github repositories Date: Wed, 27 Feb 2019 11:17:06 -0500 Message-ID: References: <20190206221308.22349-1-msantana@redhat.com> <2766343.Bn91GvS4A1@xps> <2641130.kfz5e2tDNj@xps> Mime-Version: 1.0 Content-Type: text/plain Cc: Thomas Monjalon , Michael Santana , dev@dpdk.org, Bruce Richardson , Honnappa Nagarahalli To: Luca Boccassi Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BF11B5A6A for ; Wed, 27 Feb 2019 17:17:09 +0100 (CET) In-Reply-To: (Luca Boccassi's message of "Wed, 27 Feb 2019 16:06:49 +0000") List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Luca Boccassi writes: > On Wed, 2019-02-27 at 10:53 -0500, Aaron Conole wrote: >> Thomas Monjalon writes: >> >> > 27/02/2019 15:35, Aaron Conole: >> > > Thomas Monjalon writes: >> > > > 07/02/2019 23:01, Michael Santana: >> > > > > +python3.5 -m pip install --upgrade meson --user >> > > > >> > > > Which distributions have python3.5? >> > > > It looks very specific. >> > > >> > > I agree, could probably just be python3 we need to check and see >> > > if we >> > > can just use that. >> > > >> > > But, we did need the upgrade. >> > > >> > > Travis environment comes up with ubuntu 14.04, which includes >> > > python3.4, >> > > and the requisite version of meson needs python3.5 or higher. >> > >> > It could be a python --version check then? >> >> Well, I don't know what the purpose of the version check would >> be. We >> can tailor the environments. Just need to pass the right >> information, >> that's all. I think we'll make it look nicer, though. We can do any >> environment specific fix ups in the prepare scripts, which I think >> makes >> sense. Then the build script can be a bit more generic. > > Travis supports Ubuntu 16.04 images now, which have python 3.5, I'd > suggest to just use them (dist: xenial) so you can skip all the checks > and the manual installations. Great news, thanks, Luca!