From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH v2] app/test: fix sprintf with strlcat
Date: Wed, 13 Mar 2019 09:51:29 -0400
Message-ID: <f7t5zsmrify.fsf@dhcp-25.97.bos.redhat.com>
References: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: dev@dpdk.org, reshma.pattan@intel.com, ferruh.yigit@intel.com,
 bruce.richardson@intel.com, stephen@networkplumber.org, stable@dpdk.org
To: Pallantla Poornima <pallantlax.poornima@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com>
 (Pallantla Poornima's message of "Wed, 13 Mar 2019 11:07:23 +0000")
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Pallantla Poornima <pallantlax.poornima@intel.com> writes:

> sprintf function is not secure as it doesn't check the length of string.
> More secure function strlcat is used.
>
> Fixes: 727909c592 ("app/test: introduce dynamic commands list")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> ---
> v2: Used strlcat to avoid buffer overflow.
> ---

LGTM.

Reviewed-by: Aaron Conole <aconole@redhat.com>