From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH] eal: deprecate rte_cpu_check_supported
Date: Tue, 04 Apr 2017 09:39:53 -0400
Message-ID: <f7td1cs70ly.fsf@redhat.com>
References: <20170331183122.22961-1-aconole@redhat.com>
 <2833575.ok4SoAkeVM@xps13>
Mime-Version: 1.0
Content-Type: text/plain
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id A2D79293B
 for <dev@dpdk.org>; Tue,  4 Apr 2017 15:39:55 +0200 (CEST)
In-Reply-To: <2833575.ok4SoAkeVM@xps13> (Thomas Monjalon's message of "Tue, 04
 Apr 2017 15:26:47 +0200")
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

Thomas Monjalon <thomas.monjalon@6wind.com> writes:

> 2017-03-31 14:31, Aaron Conole:
>> It's likely that this function isn't used anywhere, but since it was part of
>> the public API, mark the function for deprecation for at least one release.
>> 
>> Signed-off-by: Aaron Conole <aconole@redhat.com>

Thanks so much for the review!  I'll make sure to fix these with v2.

> [...]
>> +DPDK_17.05 {
>> +	global;
>> +
>> +	rte_cpu_is_supported;
>> +
>> +} DPDK_17.02;
>
> Should not it be a separate patch?

I thought it made sense to keep it rolled in with this patch, but if you
prefer it separate, I will do that.  Expect it as 1/2 in v2, unless you
say otherwise.

-Aaron