From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3D9C0044D for ; Wed, 11 Mar 2020 17:08:29 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A5A3F206BE for ; Wed, 11 Mar 2020 17:08:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hJ1VoryS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5A3F206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 892FA1BF7F; Wed, 11 Mar 2020 18:08:27 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 1C4B83B5 for ; Wed, 11 Mar 2020 18:08:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583946505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SiGlDlduWwxzh2toAmUt73vMzeLApsK1CSJejD6wp3k=; b=hJ1VorySTEKmu0jjCaLHZw+bvcoCVCj+PnngQUX12eGIX00FsuV7tapyiR5oEYAyxTJA5/ zjl/VISxcdzFgeaLb7v95TrIabW5BRIycEwW76PGR9lUaFM6jIovINz59nqZqxcKv9AvY1 kCfLGLVBEoCB2XNocLWCT4bijE3rAaU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-0edLdSo4M3eKI86I5S0M0g-1; Wed, 11 Mar 2020 13:08:23 -0400 X-MC-Unique: 0edLdSo4M3eKI86I5S0M0g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A6E28010EB; Wed, 11 Mar 2020 17:08:22 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50E1C19C6A; Wed, 11 Mar 2020 17:08:19 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: Harry van Haaren , dev , dpdk stable References: <20200310133304.39951-1-harry.van.haaren@intel.com> <20200311143927.76021-1-harry.van.haaren@intel.com> Date: Wed, 11 Mar 2020 13:08:18 -0400 In-Reply-To: (David Marchand's message of "Wed, 11 Mar 2020 17:15:49 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > wrote: >> >> This commit releases all service cores from their role, >> returning them to ROLE_RTE on rte_service_finalize(). >> >> This may fix an issue relating to the service cores causing > > You don't seem convinced. > > >> a race-condition on eal_cleanup(), where the service core >> could still be executing while the main thread has already >> free-d the service memory, leading to a segfault. >> >> Fixes: 21698354c832 ("service: introduce service cores concept") >> Cc: stable@dpdk.org >> >> Reported-by: David Marchand >> Reported-by: Aaron Conole >> Signed-off-by: David Marchand >> Signed-off-by: Harry van Haaren >> Acked-by: Aaron Conole > > I am okay with merging this so that we stop getting random failures of th= e ut. I think it could also potentially cause errors in user applications that regularly exit, and which use the service core architecture. So it's worth getting in now, anyway. > I will let this patch on the ml and apply on Friday at worse. > > Please take the time to reply to my question. > Thanks.