From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: Re: [PATCH] Introduce travis builds for github repositories Date: Thu, 24 Jan 2019 15:02:47 -0500 Message-ID: References: <20190123220714.20763-1-msantana@redhat.com> <41879020.unNp0mDazo@xps> Mime-Version: 1.0 Content-Type: text/plain Cc: Michael Santana , dev@dpdk.org, Bruce Richardson , Ferruh Yigit To: Thomas Monjalon Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0CA384C74 for ; Thu, 24 Jan 2019 21:02:50 +0100 (CET) In-Reply-To: <41879020.unNp0mDazo@xps> (Thomas Monjalon's message of "Thu, 24 Jan 2019 19:18:41 +0100") List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thomas Monjalon writes: > 23/01/2019 23:07, Michael Santana: >> +if [ "${NINJABUILD}" == "1" ]; then >> + meson build >> + ninja -C build >> +else >> + make config T=x86_64-native-linuxapp-${CC} >> + if [ "${SHARED}" == "1" ]; then >> + set_conf build CONFIG_RTE_BUILD_SHARED_LIB y >> + fi >> + >> + if [ "${KERNEL}" == "1" ]; then >> + echo Unsupported kernel builds at the moment >> + fi > > Do we really want to support the "make system", given that it is going > to be deprecated this year? I prefer to keep it for as long as 'make' is a supported build system. Once 'make' is deprecated (or removed, either one), it should definitely be dropped. Currently, the meson build isn't as well documented (for example, the linux build guide doesn't even refer to meson). So, most likely the average developer who just wants to make a small contribution will run 'make' to build DPDK, and hasn't learned yet how to work with meson/ninja. Are there plans for which release will officially mark 'make' as deprecated? If it will be 19.02, then let's drop this check in v2, since it won't be around long enough to provide any benefit. If it will be 19.05 or 19.08 then I think it probably will provide some value.