From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-stable] [RFC 2/2] nfp: allow for non-root user
Date: Fri, 20 Apr 2018 10:56:06 -0400
Message-ID: <f7tlgdi53ll.fsf@dhcp-25.97.bos.redhat.com>
References: <20180412222208.11770-1-aconole@redhat.com>
 <20180412222208.11770-3-aconole@redhat.com>
 <CAD+H991rVEhppb1ubjer9mjd0kg6aYBunuqd-mufKa=EPPJ3-w@mail.gmail.com>
 <f7ta7u7z10q.fsf@dhcp-25.97.bos.redhat.com>
 <CAD+H990SjAFWFjgF=xj7hTZuhnZ42bGkwuesaH6UaWM4UKb8Zg@mail.gmail.com>
 <CAD+H990-cE-UL73cQU7v9hd-RsB-6rNt7NRnpS+2JUEDzqmM4g@mail.gmail.com>
 <CAD+H992fmaux6hioFdq9+AEY6yWjpOQ5VAYLUcnkSamBEKxKoA@mail.gmail.com>
 <f7tpo2xmyis.fsf@dhcp-25.97.bos.redhat.com>
 <CAD+H992fiOF3ApEd_67VM9Ld=z-n=wSUQ+RHfcna27-r7g6g1g@mail.gmail.com>
 <f7tpo2wn18p.fsf@dhcp-25.97.bos.redhat.com>
 <CAD+H993ZxZ=idsEM1P=on3r7DFPMz7gaea1QmBjO9Uw2o6Nu=A@mail.gmail.com>
 <5d0e69b9-3655-f3f6-9cbb-1090b9471813@intel.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>, dev <dev@dpdk.org>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>, stable@dpdk.org,
 Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <5d0e69b9-3655-f3f6-9cbb-1090b9471813@intel.com> (Ferruh Yigit's
 message of "Fri, 20 Apr 2018 15:12:28 +0100")
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Ferruh Yigit <ferruh.yigit@intel.com> writes:

> On 4/19/2018 7:05 AM, Alejandro Lucero wrote:
>> On Wed, Apr 18, 2018 at 1:32 PM, Aaron Conole <aconole@redhat.com> wrote:
>> 
>>> Alejandro Lucero <alejandro.lucero@netronome.com> writes:
>>>
>>>> On Tue, Apr 17, 2018 at 8:19 PM, Aaron Conole <aconole@redhat.com>
>>> wrote:
>>>>
>>>>  Alejandro Lucero <alejandro.lucero@netronome.com> writes:
>>>>
>>>>  > I was just wondering, if device device PCI sysfs resource files or
>>> VFIO group /dev files
>>>>  require to change
>>>>  > permissions for non-root users, does it not make sense to adjust also
>>> /var/lock in the
>>>>  system?
>>>>
>>>>  For the /dev, we use udev rules - so the correct individual vfio device
>>>>  files get assigned the correct permissions.  No such mechanism exists
>>>>  for /var/lock as far as I can tell.
>>>>
>>>>  Ex. see:
>>>>
>>>>  https://github.com/openvswitch/ovs/blob/master/
>>> rhel/usr_lib_udev_rules.d_91-vfio.rules
>>>>
>>>>
>>>>  Maybe something similar exists that we could use to generate the lock
>>>>  file automatically?
>>>>
>>>> What about /sysfs/bus/pci/device/$PCI_DEV/resource file?
>>>>
>>>> Is RH forcing OVS DPDK to only work if the host has IOMMU support?
>>>
>>> Yes.
>>>
>> 
>> Ok then. It makes sense now to apply this patch to stable versions.
>> 
>> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>
> Since the target is the stable tree, I will drop them from patchwork as not
> applicable.
>
> Can you please send v1 of the patch to the stable mail list, it can be good idea
> to cc stable maintainers as well.

Will do.  I'll spin into a proper series and submit next week.

Sorry for the extra noise, Ferruh.