From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH 1/1] eal: return true or false from lcore
	role check function
Date: Tue, 09 Jan 2018 11:44:39 -0500
Message-ID: <f7ttvvv3rt4.fsf@dhcp-25.97.bos.redhat.com>
References: <1515005015-31990-1-git-send-email-erik.g.carrillo@intel.com>
 <1515005015-31990-2-git-send-email-erik.g.carrillo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: pbhagavatula@caviumnetworks.com, harry.van.haaren@intel.com, dev@dpdk.org
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id ED34E1B1D0
 for <dev@dpdk.org>; Tue,  9 Jan 2018 17:44:41 +0100 (CET)
In-Reply-To: <1515005015-31990-2-git-send-email-erik.g.carrillo@intel.com>
 (Erik Gabriel Carrillo's message of "Wed, 3 Jan 2018 12:43:35 -0600")
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Erik,

Erik Gabriel Carrillo <erik.g.carrillo@intel.com> writes:

> Update rte_lcore_has_role() so that it returns true/false instead of
> success/failure.
>
> Fixes: 78666372fa2b ("eal: add function to check lcore role")
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---

I believe this breaks the published abi - Success is now 'true', and
failure is 'false';  previously success would be 0 == false.  You'll
need to invert the test, or note that the abi is breaking (since
semantically any caller will need to invert the test).