From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH v5 10/20] pci: avoid inlining functions
Date: Wed, 18 Oct 2017 10:30:20 -0400
Message-ID: <f7tvajco7er.fsf@dhcp-25-97.bos.redhat.com>
References: <cover.1507795823.git.gaetan.rivet@6wind.com>
 <cover.1507804944.git.gaetan.rivet@6wind.com>
 <cover.1507804944.git.gaetan.rivet@6wind.com>
 <35d2cbe2bb9d8c03d0564256a85cce54b8331eee.1507804944.git.gaetan.rivet@6wind.com>
 <f7tvajdr5z6.fsf@dhcp-25-97.bos.redhat.com>
 <20171018085432.GC3596@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: =?utf-8?Q?Ga=C3=ABtan?= Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 8FCB13790
 for <dev@dpdk.org>; Wed, 18 Oct 2017 16:30:23 +0200 (CEST)
In-Reply-To: <20171018085432.GC3596@bidouze.vm.6wind.com> (=?utf-8?Q?=22Ga?=
 =?utf-8?Q?=C3=ABtan?= Rivet"'s
 message of "Wed, 18 Oct 2017 10:54:32 +0200")
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Ga=C3=ABtan Rivet <gaetan.rivet@6wind.com> writes:

> On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote:
>> Gaetan Rivet <gaetan.rivet@6wind.com> writes:
>>=20
>> > Parsing operations should not happen in performance critical sections.
>> > Headers should not propose implementations unless duly required.
>> >
>> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>> > ---
>>=20
>> Can these cleanups be done before the move in patch 3?
>
> Sure.
>
> I wanted to minimize the changes before moving the code. If I had rework
> to do on these patches, I wanted to avoid having to redo the move and
> verify the changes were properly propagated.

I use 'git rebase -i' to do changes; it can take care of moving through
a stack of changes.

> But if it is necessary, these changes can happen before moving the whole
> lot.

I think it's better to do all the changes before hand.  If there is a
change that could be part of a bug fix, it can be easily backported to
stable branches.