From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y Date: Thu, 13 Apr 2017 12:11:58 +0530 Message-ID: References: <357262EF-AA7B-4064-963E-FF130E4607E6@atomicrules.com> <59AF69C657FD0841A61C55336867B5B06675640D@IRSMSX103.ger.corp.intel.com> <8154073.47RD1mYHR3@xps13> <20170412215520.44c485a2@neon> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: "Richardson, Bruce" , john miller , To: Olivier MATZ , Thomas Monjalon Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0045.outbound.protection.outlook.com [104.47.38.45]) by dpdk.org (Postfix) with ESMTP id DA1B32C6E for ; Thu, 13 Apr 2017 08:35:21 +0200 (CEST) In-Reply-To: <20170412215520.44c485a2@neon> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thursday 13 April 2017 01:25 AM, Olivier MATZ wrote: > Hi, > > On Wed, 12 Apr 2017 14:31:56 +0200 > Thomas Monjalon wrote: > >> 2017-04-12 11:31, Richardson, Bruce: >>> [...] >> >> I think the default mempool could be linked. >> I don't know how easy it is to transform >> CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="ring_mp_mc" >> into >> -lrte_mempool_ring >> >> Anyone for a patch? > > This is the default mempool for the mbufs, selected when using the > function rte_pktmbuf_pool_create(). > > For non-mbuf mempools, the default is to use the ring handler (see > in rte_mempool_create()). > > So if we want option 2-, it looks that moving this line in rte.app.mk > above, outside the if (shared build), would do the job: > > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring > > I think both 2- and 3- are acceptable. People using the shared library > mode should already provide all the .so in a known location, so that > they are loaded by default. This is needed for the PMDs for instance. > I can send the patch; before that, should this fact, that ring is included by default, is to be documented somewhere? - Shreyansh