public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Marat Khalili <marat.khalili@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: RE: [PATCH 3/6] test: fix race condition in ELF load tests
Date: Tue, 20 Jan 2026 10:30:25 +0000	[thread overview]
Message-ID: <f8dbb6cf64ae45618195580be788b59c@huawei.com> (raw)
In-Reply-To: <20260119160326.06a6094c@phoenix.local>

> > P.S. Did not worth its own patch, but since you are working on it can you also
> > do s/sizeof(struct rte_mbuf)/RTE_MBUF_DEFAULT_BUF_SIZE/g ? I overlooked it last
> > time.
> 
> 
> Where is that bit?

This in app/test/test_bpf.c is a mix of two worlds:

```c
        const struct rte_bpf_prm prm = {
                .prog_arg = {
                        .type = RTE_BPF_ARG_PTR,
                        .size = sizeof(struct rte_mbuf),
                },
        };
```

The pointer points to the mbuf buffer, but the size is provided for the mbuf 
struct.

Now that I think of it, what lib/bpf/bpf_pkt.c passes to BPF program is not a 
pointer to the mbuf buffer, but a pointer to the packet data which is bigger by 
RTE_PKTMBUF_HEADROOM, so we should probably specify RTE_MBUF_DEFAULT_DATAROOM 
in the size member for our case.

  reply	other threads:[~2026-01-20 10:30 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-18 20:09 [PATCH 0/6] test: fix sporadic failures on high core count systems Stephen Hemminger
2026-01-18 20:09 ` [PATCH 1/6] test: add pause to synchronization spinloops Stephen Hemminger
2026-01-18 20:09 ` [PATCH 2/6] test: fix timeout for atomic test on high core count systems Stephen Hemminger
2026-01-18 20:09 ` [PATCH 3/6] test: fix race condition in ELF load tests Stephen Hemminger
2026-01-19 11:42   ` Marat Khalili
2026-01-20  0:03     ` Stephen Hemminger
2026-01-20 10:30       ` Marat Khalili [this message]
2026-01-19 18:24   ` Stephen Hemminger
2026-01-18 20:09 ` [PATCH 4/6] test: fix unsupported BPF instructions in elf load test Stephen Hemminger
2026-01-19 11:43   ` Marat Khalili
2026-01-18 20:09 ` [PATCH 5/6] test: add file-prefix for all fast-tests on Linux Stephen Hemminger
2026-01-19 13:06   ` Marat Khalili
2026-01-19 14:01     ` Bruce Richardson
2026-01-18 20:09 ` [PATCH 6/6] test: fix trace_autotest_with_traces parallel execution Stephen Hemminger
2026-01-19 13:13   ` Marat Khalili
2026-01-20  0:07     ` Stephen Hemminger
2026-01-20 11:36       ` Marat Khalili
2026-01-22  0:50 ` [PATCH v3 00/14] test: fix test failures on high cores Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 01/14] test: add pause to synchronization spinloops Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 02/14] test: scale atomic test based on core count Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 03/14] test/mcslock: scale test based on number of cores Stephen Hemminger
2026-01-22 10:41     ` Konstantin Ananyev
2026-01-27 20:31       ` Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 04/14] test/stack: " Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 05/14] test/timer: " Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 06/14] test/bpf: fix error handling in ELF load tests Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 07/14] test/bpf: fix unsupported BPF instructions in ELF load test Stephen Hemminger
2026-01-22 10:33     ` Konstantin Ananyev
2026-01-22  0:50   ` [PATCH v3 08/14] test/bpf: skip ELF test if null PMD disabled Stephen Hemminger
2026-01-23 11:56     ` Marat Khalili
2026-01-22  0:50   ` [PATCH v3 09/14] test: add file-prefix for all fast-tests on Linux Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 10/14] test: fix trace_autotest_with_traces parallel execution Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 11/14] test/eventdev: skip test if eventdev driver disabled Stephen Hemminger
2026-01-22 20:40     ` Stephen Hemminger
2026-01-23  9:06       ` Bruce Richardson
2026-01-22  0:50   ` [PATCH v3 12/14] test/pcapng: skip test if null driver missing Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 13/14] test/vdev: skip test if no null PMD Stephen Hemminger
2026-01-22  0:50   ` [PATCH v3 14/14] test/bpf: pass correct size for Rx/Tx load tests Stephen Hemminger
2026-01-23 11:50     ` Marat Khalili
2026-03-05 16:39   ` [PATCH v3 00/14] test: fix test failures on high cores David Marchand
2026-03-05 17:50 ` [PATCH v4 00/11] test: fix test failures on high core count systems Stephen Hemminger
2026-03-05 17:50   ` [PATCH v4 01/11] test: add pause to synchronization spinloops Stephen Hemminger
2026-03-05 17:50   ` [PATCH v4 02/11] test/atomic: scale test based on core count Stephen Hemminger
2026-03-05 17:50   ` [PATCH v4 03/11] test/mcslock: scale test based on number of cores Stephen Hemminger
2026-03-05 17:50   ` [PATCH v4 04/11] test/stack: " Stephen Hemminger
2026-03-05 17:50   ` [PATCH v4 05/11] test/timer: " Stephen Hemminger
2026-03-05 17:51   ` [PATCH v4 06/11] test/timer: replace volatile with C11 atomics Stephen Hemminger
2026-03-05 17:51   ` [PATCH v4 07/11] test: add file-prefix for all fast-tests on Linux Stephen Hemminger
2026-03-05 17:51   ` [PATCH v4 08/11] test: fix trace_autotest_with_traces parallel execution Stephen Hemminger
2026-03-05 17:51   ` [PATCH v4 09/11] test/bpf: fix error handling in ELF load tests Stephen Hemminger
2026-03-05 17:51   ` [PATCH v4 10/11] test/bpf: fix unsupported BPF instructions in ELF load test Stephen Hemminger
2026-03-05 17:51   ` [PATCH v4 11/11] test/bpf: pass correct size for Rx/Tx load tests Stephen Hemminger
2026-03-17 13:28   ` [PATCH v4 00/11] test: fix test failures on high core count systems Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8dbb6cf64ae45618195580be788b59c@huawei.com \
    --to=marat.khalili@huawei.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox