From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 2/2] net/ena: update ena_com to the newer
 version
Date: Mon, 11 Jun 2018 11:42:45 +0100
Message-ID: <f9dfdb44-b197-8ed3-1607-2d0cc8aa364c@intel.com>
References: <a8be4828-323c-31be-475a-1380c506acb9@intel.com>
 <20180611095416.12250-1-mk@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik <rk@semihalf.com>
To: Michal Krawczyk <mk@semihalf.com>, Marcin Wojtas <mw@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 5921C1DDBB
 for <dev@dpdk.org>; Mon, 11 Jun 2018 12:42:49 +0200 (CEST)
In-Reply-To: <20180611095416.12250-1-mk@semihalf.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/11/2018 10:54 AM, Michal Krawczyk wrote:
> ena_com is the HAL provided by the vendor and it shouldn't be modified
> by the driver developers.
> 
> The PMD and platform file was adjusted for the new version of the
> ena_com:
>     * Do not use deprecated meta descriptor fields
>     * Add empty AENQ handler structure with unimplemented handlers
>     * Add memzone allocations count to ena_ethdev.c file - it was
>       removed from ena_com.c file
>     * Add new macros used in new ena_com files
>     * Use error code ENA_COM_UNSUPPORTED instead of ENA_COM_PERMISSION
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> Signed-off-by: Rafal Kozik <rk@semihalf.com>

Can you please check following?

.../dpdk/drivers/net/ena/base/ena_com.c: In function ‘ena_com_aenq_intr_handler’:
.../dpdk/drivers/net/ena/base/ena_com.c:1833:21: error: variable ‘timestamp’ set
but not used [-Werror=unused-but-set-variable]
  unsigned long long timestamp;
                     ^~~~~~~~~