From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Timothy M. Redaelli" <tredaelli@redhat.com>
Subject: Re: [PATCH v3 01/17] build: add initial infrastructure
 for meson & ninja builds
Date: Wed, 20 Sep 2017 12:10:19 +0200
Message-ID: <f9e3472d-9a8f-d7e1-64a1-3c51c319bac2@redhat.com>
References: <20170912103809.140473-1-bruce.richardson@intel.com>
 <20170913141222.253688-1-bruce.richardson@intel.com>
 <20170913141222.253688-2-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: nhorman@tuxdriver.com, luca.boccassi@gmail.com,
 harry.van.haaren@intel.com, keith.wiles@intel.com
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 266F01F5
 for <dev@dpdk.org>; Wed, 20 Sep 2017 12:10:24 +0200 (CEST)
In-Reply-To: <20170913141222.253688-2-bruce.richardson@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/13/2017 04:12 PM, Bruce Richardson wrote:
[...]
> +
> +# for static libs, treat the drivers as regular libraries, otherwise
> +# for shared libs, put them in a driver folder
> +if get_option('default_library') == 'static'
> +	driver_install_path = get_option('libdir')
> +else
> +	driver_install_path = join_paths(get_option('datadir'), 'dpdk/drivers')
> +endif

This is against hier, since:
"This directory contains subdirectories with specific application data,
that can be shared among different architectures of the same OS."
(from man 7 hier)

Please consider to use a subdirectory of libdir like the actual dpdk
instead.