From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v2 2/4] drivers: prefix global variables with
 module name
Date: Mon, 8 Oct 2018 17:48:52 +0530
Message-ID: <fa51a348-9a65-697b-de29-ce5008bd6056@nxp.com>
References: <20181004034047.26824-1-ferruh.yigit@intel.com>
 <20181005162612.31906-1-ferruh.yigit@intel.com>
 <20181005162612.31906-2-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Reshma Pattan <reshma.pattan@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Ashish Gupta <ashish.gupta@cavium.com>, Fiona Trahe <fiona.trahe@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty
 <declan.doherty@intel.com>, Fan Zhang <roy.fan.zhang@intel.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Gaetan Rivet <gaetan.rivet@6wind.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Rasesh Mody <rasesh.mody@cavium.com>, Harish Patil
 <harish.patil@cavium.com>, Shahed Shaikh <shahed.shaikh@cavium.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Keith Wiles <ke
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50])
 by dpdk.org (Postfix) with ESMTP id B55C258F6
 for <dev@dpdk.org>; Mon,  8 Oct 2018 14:19:25 +0200 (CEST)
In-Reply-To: <20181005162612.31906-2-ferruh.yigit@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote:
> Some global variables are defined with generic names, add component name
> as prefix to variables to prevent collusion with application variables.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>   drivers/bus/dpaa/include/fsl_fman_crc64.h     |  8 ++--

[...]

> 
> diff --git a/drivers/bus/dpaa/include/fsl_fman_crc64.h b/drivers/bus/dpaa/include/fsl_fman_crc64.h
> index bf162f3ac..08ad63042 100644
> --- a/drivers/bus/dpaa/include/fsl_fman_crc64.h
> +++ b/drivers/bus/dpaa/include/fsl_fman_crc64.h
> @@ -42,9 +42,9 @@ struct fman_crc64_t {
>   	uint64_t initial;
>   	uint64_t table[1 << 8];
>   };
> -extern struct fman_crc64_t FMAN_CRC64_ECMA_182;
> +extern struct fman_crc64_t fman_crc64_ecma_182;
>   #define DECLARE_FMAN_CRC64_TABLE() \
> -struct fman_crc64_t FMAN_CRC64_ECMA_182 = { \
> +struct fman_crc64_t fman_crc64_ecma_182 = { \
>   	0xFFFFFFFFFFFFFFFFULL, \
>   	{ \
>   		0x0000000000000000ULL, 0xb32e4cbe03a75f6fULL, \
> @@ -183,7 +183,7 @@ struct fman_crc64_t FMAN_CRC64_ECMA_182 = { \
>    */
>   static inline uint64_t fman_crc64_init(void)
>   {
> -	return FMAN_CRC64_ECMA_182.initial;
> +	return fman_crc64_ecma_182.initial;
>   }
>   
>   /* Updates the CRC with arbitrary data */
> @@ -192,7 +192,7 @@ static inline uint64_t fman_crc64_update(uint64_t crc,
>   {
>   	uint8_t *p = data;
>   	while (len--)
> -		crc = FMAN_CRC64_ECMA_182.table[(crc ^ *(p++)) & 0xff] ^
> +		crc = fman_crc64_ecma_182.table[(crc ^ *(p++)) & 0xff] ^
>   				(crc >> 8);
>   	return crc;
>   }

[...]

For the change above:

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>