From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 15/31] net/ice: support device
 initialization
Date: Mon, 17 Dec 2018 22:29:14 +0000
Message-ID: <fba5e835-d406-87eb-a366-131b9b5ceca3@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-16-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 4D8F51B9BD
 for <dev@dpdk.org>; Mon, 17 Dec 2018 23:29:19 +0100 (CET)
In-Reply-To: <1545032259-77179-16-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Update the documents too.
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
>  MAINTAINERS                             |   2 +
>  config/common_base                      |   7 +
>  doc/guides/nics/features/ice.ini        |  11 +
>  doc/guides/nics/ice.rst                 |  80 ++++
>  doc/guides/nics/index.rst               |   1 +
>  doc/guides/rel_notes/release_19_02.rst  |   5 +
>  drivers/net/Makefile                    |   1 +
>  drivers/net/ice/Makefile                |  54 +++
>  drivers/net/ice/base/meson.build        |  27 ++
>  drivers/net/ice/ice_ethdev.c            | 636 ++++++++++++++++++++++++++++++++
>  drivers/net/ice/ice_ethdev.h            | 305 +++++++++++++++
>  drivers/net/ice/ice_logs.h              |  45 +++
>  drivers/net/ice/ice_rxtx.h              | 117 ++++++

I guess intention is to put this file (ice_rxtx.h) into next patch (16/31), file
seems not used in this patch.

<...>

> +RTE_PMD_REGISTER_PCI(net_ice, rte_ice_pmd);
> +RTE_PMD_REGISTER_PCI_TABLE(net_ice, pci_id_ice_map);
> +RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* igb_uio | uio_pci_generic | vfio-pci");

Also needs to set "RTE_PMD_REGISTER_PARAM_STRING()" macro here.

<...>