From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 4/4] app/testpmd: display/clear forwarding
 stats on demand
Date: Wed, 20 Mar 2019 13:29:22 +0000
Message-ID: <fbec222d-1b11-5802-08cc-bb3fd2b19eb8@intel.com>
References: <1552318522-18777-1-git-send-email-david.marchand@redhat.com>
 <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
 <1553076154-3907-5-git-send-email-david.marchand@redhat.com>
 <48cc01e4-08fe-40b2-cbe6-86db8bc9110e@intel.com>
 <CAJFAV8yunZ0Ay27ZV_RYCeWJQYWf-kvNz6OyraBb3dcus-PVfg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev <dev@dpdk.org>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 Rami Rosen <ramirose@gmail.com>, Andrew Rybchenko <arybchenko@solarflare.com>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id D766D5F14
 for <dev@dpdk.org>; Wed, 20 Mar 2019 14:29:28 +0100 (CET)
In-Reply-To: <CAJFAV8yunZ0Ay27ZV_RYCeWJQYWf-kvNz6OyraBb3dcus-PVfg@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/20/2019 12:44 PM, David Marchand wrote:
> On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 3/20/2019 10:02 AM, David Marchand wrote:
>     > Add a new "show/clear fwd stats all" command to display fwd and port
>     > statistics on the fly.
> 
>     Won't this be duplicating existing commands:
>     "show port stats all|<port_id>"
>     "clear port stats all|<port_id>"
> 
>     What benefit "show/clear fwd stats all" adds against existing ones?
> 
> 
> Forwarding engines like "iofwd" maintain software statistics like "fwd_dropped"
> which gives you how much of the packets to be transmitted could not make it to
> the "wire".
> "show port stats" won't give you those stats.
> 
> You could stop/start the forwarding to get them, but when debugging you most
> likely do not want to stop the forwarding.
> I have been using this while tracking drops in a PVP setup.

I see, they are slightly different, no objection from me.