From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] net/pcap: convert license headers to SPDX
	tags
Date: Tue, 19 Dec 2017 10:32:51 +0530
Message-ID: <fc012ed5-f173-e5ec-5aa5-6cc42cd31ffa@nxp.com>
References: <20171218210616.37502-1-ferruh.yigit@intel.com>
 <26b4b915-abf5-4eda-7187-827666f30167@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Bruce Richardson <bruce.richardson@intel.com>, John McNamara
 <john.mcnamara@intel.com>, <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0077.outbound.protection.outlook.com [104.47.40.77])
 by dpdk.org (Postfix) with ESMTP id 64DA81DBF
 for <dev@dpdk.org>; Tue, 19 Dec 2017 06:02:58 +0100 (CET)
In-Reply-To: <26b4b915-abf5-4eda-7187-827666f30167@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

HI Ferruh,

On 12/19/2017 2:48 AM, Ferruh Yigit wrote:
> On 12/18/2017 1:06 PM, Ferruh Yigit wrote:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> <...>
>
>> + * SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>> + * Copyright(c) 2014 6WIND S.A.
>> + * All rights reserved.
>>   */
>
> Hi Hemant, Thomas,
>
> Can you please suggest about extra "All rights reserved." line.
>
> It is in the part of the BSD header, and I _assume_ that has been intended to
> cover all "Copyright" lines above it.
> But since some of the Copyright holders (at least Intel ones) already has that
> in same line with copyright and I _assume_ this is intentional because of legal
> requirements, can we remove that line.
>
> I guess we have two options while removing it, applying it to all previous
> Copyright lines (B) or just remove it (A):
>
> (A)
>  SPDX-License-Identifier: BSD-3-Clause
>  Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>  Copyright(c) 2014 6WIND S.A.
>
> (B)
>  SPDX-License-Identifier: BSD-3-Clause
>  Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>  Copyright(c) 2014 6WIND S.A. All rights reserved.
>
>
> Can we go with option (A)?
>

"All rights reserved" depend on legal counsel.
e.g Freescale preferred it, with NXP migration, we have stopped doing it.

w.r.t your query, I will suggest option (c)
SPDX-License-Identifier: BSD-3-Clause
Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
Copyright(c) 2014 6WIND S.A.
All rights reserved.

i.e no change in copyright.

However, as Bruce mentioned, we can remove *All rights reserved*  for 
the files having duplicate statement for a single copyright.