From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/avp: fix build with non x86 Date: Mon, 3 Apr 2017 15:23:10 +0100 Message-ID: References: <1491227915-9410-1-git-send-email-jerin.jacob@caviumnetworks.com> <70A7408C6E1BFB41B192A929744D8523968FFB96@ALA-MBC.corp.ad.wrs.com> <20170403142204.jj3dgw4xxfc4pv4i@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: Jerin Jacob , "Legacy, Allain" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 40D60326C for ; Mon, 3 Apr 2017 16:23:12 +0200 (CEST) In-Reply-To: <20170403142204.jj3dgw4xxfc4pv4i@localhost.localdomain> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/3/2017 3:22 PM, Jerin Jacob wrote: > On Mon, Apr 03, 2017 at 02:10:41PM +0000, Legacy, Allain wrote: >>> -----Original Message----- >>> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] >>> Sent: Monday, April 03, 2017 9:59 AM >>> To: dev@dpdk.org >>> Cc: YIGIT, FERRUH; Legacy, Allain; Jerin Jacob >>> Subject: [dpdk-dev] [PATCH] net/avp: fix build with non x86 >>> >>> sys/io.h is an x86 specific header file and AVP driver is not using any x86 >>> specific IO operation. Hence removing the sys/io.h reference to fix the build >>> issue on non x86 platforms. >>> >>> Fixes: 5567f9689cf8 ("net/avp: support driver registration") >>> >>> Signed-off-by: Jerin Jacob >> >> In addition to this, since we do not support AVP devices on anything but x86_64 perhaps it would be appropriate to avoid compilation altogether on other architectures. That is, by disabling CONFIG_RTE_LIBRTE_AVP_PMD by default and only enabling for x86_64 on icc/gcc/clang for linuxapp? > > If that is the case then Please send a patch to fix it appropriately. +1