From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F879C07E96 for ; Fri, 9 Jul 2021 02:59:26 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id BAC836112D for ; Fri, 9 Jul 2021 02:59:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAC836112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6CD54014D; Fri, 9 Jul 2021 04:59:24 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 7E33240143; Fri, 9 Jul 2021 04:59:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="270749689" X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="270749689" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 19:59:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="628714272" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 08 Jul 2021 19:59:21 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 19:59:18 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 9 Jul 2021 10:59:09 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.010; Fri, 9 Jul 2021 10:59:09 +0800 From: "Zhang, Qi Z" To: "Yu, DapengX" , "Yang, Qiming" CC: "dev@dpdk.org" , "Guo, Junfeng" , "Yan, Zhirun" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/ice/base: fix VXLAN flow director creation error Thread-Index: AQHXYk3i/fIVeRnciEypiI4fBnImDKs6GAWA Date: Fri, 9 Jul 2021 02:59:08 +0000 Message-ID: References: <20210616012053.201105-1-dapengx.yu@intel.com> In-Reply-To: <20210616012053.201105-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice/base: fix VXLAN flow director creation error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yu, DapengX > Sent: Wednesday, June 16, 2021 9:21 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Guo, Junfeng ; Yan, Zhirun > ; Yu, DapengX ; > stable@dpdk.org > Subject: [PATCH 1/2] net/ice/base: fix VXLAN flow director creation error >=20 > From: Dapeng Yu >=20 > In original implementation, error returned when creating VXLAN flow direc= tor > with SCTP or TCP as layer 4 protocol of inner segment. >=20 > There are several root causes for the error: > 1. ice_fdir_udp4_vxlan_pkt[] is not adapted to the TCP and SCTP protocol. > Its length cannot hold TCP header, only UDP protocol was supported in ori= ginal > implementation 2. VXLAN VNI offset: 45 is inconsistent with IETF RFC 7348 >=20 > This patch fixes those defects described above. >=20 > Fixes: 608cd0a5e283 ("net/ice/base: support VXLAN VNI field in flow direc= tor") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi