From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] ether: fix incorrect stats query for lowest xstat id Date: Tue, 6 Feb 2018 17:42:19 +0000 Message-ID: References: <20180206160659.87323-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson , thomas@monjalon.net Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 64EA81B6DE for ; Tue, 6 Feb 2018 18:42:22 +0100 (CET) In-Reply-To: <20180206160659.87323-1-bruce.richardson@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/6/2018 4:06 PM, Bruce Richardson wrote: > When querying either the name or the value of a stat using the xstats > APIs, a check is done to see if the regular stats API or the xstats APIs > for the driver need to be used. However, the id of the stat requested is > checked to see if it is greater than the number of basic stats, rather > than checking for greater-or-equal, meaning that the xstat with the lowest > id gets incorrectly treated as a basic stat. > > This problem manifests itself when you call proc_info using "--xstats-id" > for the first xstat, you get no name of the stat printed, and a random(ish) > stat value. > > Fixes: 4773152f850b ("ethdev: optimize xstats by ids APIs") > > Signed-off-by: Bruce Richardson Reviewed-by: Ferruh Yigit