From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3] net/virtio-user: check negotiated features before set Date: Mon, 10 Sep 2018 15:42:47 +0200 Message-ID: References: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: zhihong.wang@intel.com, dev@dpdk.org, Allain.Legacy@windriver.com, Matt.Peters@windriver.com To: eric zhang , tiwei.bie@intel.com Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 2167511A4 for ; Mon, 10 Sep 2018 15:42:52 +0200 (CEST) In-Reply-To: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/29/2018 05:55 PM, eric zhang wrote: > This patch checks negotiated features to see if necessary to offload > before set the tap device offload capabilities. It also checks if kernel > support the TUNSETOFFLOAD operation. > > Signed-off-by: eric zhang > > --- > v3: > * make other offloading features depend on CSUM > * check IFF_VNET_HDR support when handling VHOST_GET_FEATURES > > --- > v2: > * don't return failure when failed to set offload to tap > * check if offloads available when handling VHOST_GET_FEATURES > --- > drivers/net/virtio/virtio_user/vhost_kernel.c | 18 +++++--- > drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 56 +++++++++++++++++------ > drivers/net/virtio/virtio_user/vhost_kernel_tap.h | 2 +- > 3 files changed, 54 insertions(+), 22 deletions(-) > Applied to dpdk-next-virtio/master, adding Fixes: line as suggested by Tiwei. Thanks, Maxime