From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] kni: implement header_ops parse method
Date: Tue, 2 Oct 2018 17:58:33 +0100
Message-ID: <fd2a09e1-8c8a-af3a-b3a2-aaa4b9969650@intel.com>
References: <20180927000224.4011-1-iryzhov@nfware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Igor Ryzhov <iryzhov@nfware.com>, dev@dpdk.org,
 Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 9A61D683E
 for <dev@dpdk.org>; Tue,  2 Oct 2018 18:58:42 +0200 (CEST)
In-Reply-To: <20180927000224.4011-1-iryzhov@nfware.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/27/2018 1:02 AM, Igor Ryzhov wrote:
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Hi Igor,

What is the motivation to add this support? What is enabled by this?


Meanwhile, why we are not using eth_header_ops, which is already set by
ether_setup().
To disable .cache & .cache_update?

If so why not using relevant eth_header_ops (eth_header, eth_header_parse ..)
instead of implementing ours?

> ---
>  kernel/linux/kni/kni_net.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index 7fcfa106c..128a5477c 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct net_device *dev,
>  	return dev->hard_header_len;
>  }
>  
> +/*
> + *  Extract hardware address from packet
> + */
> +static int
> +kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
> +{
> +	const struct ethhdr *eth = eth_hdr(skb);
> +
> +	memcpy(haddr, eth->h_source, ETH_ALEN);
> +
> +	return ETH_ALEN;
> +}
> +
>  /*
>   * Re-fill the eth header
>   */
> @@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev, bool new_carrier)
>  
>  static const struct header_ops kni_net_header_ops = {
>  	.create  = kni_net_header,
> +	.parse   = kni_net_header_parse,
>  #ifdef HAVE_REBUILD_HEADER
>  	.rebuild = kni_net_rebuild_header,
>  #endif /* < 4.1.0  */
>