From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 15/18] net/ixgbe: parse flow director filter
Date: Tue, 20 Dec 2016 17:00:38 +0000
Message-ID: <fd2a2254-3243-b5eb-6011-4180eb121cdc@intel.com>
References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com>
 <1480675394-59179-16-git-send-email-wei.zhao1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: wenzhuo.lu@intel.com
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1A405FA88
 for <dev@dpdk.org>; Tue, 20 Dec 2016 18:00:42 +0100 (CET)
In-Reply-To: <1480675394-59179-16-git-send-email-wei.zhao1@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/2/2016 10:43 AM, Wei Zhao wrote:
> From: wei zhao1 <wei.zhao1@intel.com>
> 
> check if the rule is a flow director rule, and get the flow director info.
> 
> Signed-off-by: wei zhao1 <wei.zhao1@intel.com>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---

<...>

> +	PATTERN_SKIP_VOID(rule, struct ixgbe_fdir_rule,
> +			  RTE_FLOW_ERROR_TYPE_ITEM_NUM);
> +	if (item->type != RTE_FLOW_ITEM_TYPE_ETH &&
> +	    item->type != RTE_FLOW_ITEM_TYPE_IPV4 &&
> +	    item->type != RTE_FLOW_ITEM_TYPE_IPV6 &&
> +	    item->type != RTE_FLOW_ITEM_TYPE_UDP &&
> +	    item->type != RTE_FLOW_ITEM_TYPE_VXLAN &&
> +	    item->type != RTE_FLOW_ITEM_TYPE_NVGRE) {

This gives build error [1], there are a few more same usage:

.../drivers/net/ixgbe/ixgbe_ethdev.c:9238:17: error: comparison of
constant 241 with expression of type 'const enum rte_flow_item_type' is
always true [-Werror,-Wtautological-constant-out-of-range-compare]
            item->type != RTE_FLOW_ITEM_TYPE_NVGRE) {