From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v6 4/4] test: add unit test for pdump library
Date: Thu, 26 Jul 2018 11:02:23 +0100
Message-ID: <fd2bed81-0b1a-d240-9612-2a9dde665b3a@intel.com>
References: <1532429671-1606-1-git-send-email-naga.sureshx.somarowthu@intel.com>
 <1532538360-8773-1-git-send-email-naga.sureshx.somarowthu@intel.com>
 <1532538360-8773-5-git-send-email-naga.sureshx.somarowthu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: remy.horton@intel.com, reshma.pattan@intel.com
To: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 0B1C43237
 for <dev@dpdk.org>; Thu, 26 Jul 2018 12:02:25 +0200 (CEST)
In-Reply-To: <1532538360-8773-5-git-send-email-naga.sureshx.somarowthu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 25-Jul-18 6:06 PM, Naga Suresh Somarowthu wrote:
> Unit test cases are added for pdump library.
> Primary process will act as server, forks a child secondary process.
> Secondary process acts as client.
> Server will do pdump init to serve any pdump client requests.
> Server will create a vdev, send/receive packets continuously
> in a separate thread.
> Client will create virtual rings to receive the packet dump.
> Client sends pdump enable/disable requests using either port/device id.
> Packet flow direction can be tx/rx/tx&rx.
> In Server, appropriate pdump callbacks are triggered,
> when packets are transmitted/received.
> Pdump packet is copied to client rings.
> 
> Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> ---

<snip>

> +
> +#define QUEUE_ID 0
> +#define NUM_ITR 3
> +
> +#ifdef RTE_EXEC_ENV_BSDAPP
> +#define self "curproc"
> +#define exe "file"
> +#else
> +#define self "self"
> +#define exe "exe"
> +#endif

Why is all of this here? This looks like a copy paste from process.h

> +
> +/* sample test to send packets to the pdump client recursively */
> +void *send_pkts(void *port);
> +
> +/* Sample test to create setup for the pdump server tests */
> +int test_pdump_init(void);
> +
> +/* Sample test to teardown the pdump server setup */
> +int test_pdump_uninit(void);
> +
> +/* Sample test to run the pdump client tests */
> +int run_pdump_client_tests(void);
> +
> +/* Sample test to run the pdump server tests */
> +int run_pdump_server_tests(void);
> +
> +/* Sample test to run the pdump client and server tests based on
> + * the process type
> + */
> +int test_pdump(void);
> +
> +#endif /* _TEST_PDUMP_H_ */
> 


-- 
Thanks,
Anatoly