From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification Date: Fri, 29 Mar 2019 15:09:09 +0000 Message-ID: References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> <3804007.JU0OzdjkKo@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@dpdk.org, dev@dpdk.org To: Thomas Monjalon , Hajkowski , david.hunt@intel.com Return-path: In-Reply-To: <3804007.JU0OzdjkKo@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29-Mar-19 2:14 PM, Thomas Monjalon wrote: > 18/03/2019 12:56, Hajkowski: >> From: Marcin Hajkowski >> --- a/doc/guides/rel_notes/release_19_05.rst >> +++ b/doc/guides/rel_notes/release_19_05.rst >> @@ -120,6 +120,8 @@ API Changes >> + * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions >> + have been modified to be thread safe. > > The deprecation notice was recently sent, > so I guess this patch is for DPDK 19.08. Yes, this is changing API so the target was 19.08. However, first patch is a fix and can be applied to 19.05 as well. The API documentation stated that the function was not thread safe, but the code itself was thread safe (it wasn't because it was buggy, but the intention of being thread safe was there), so this could be considered fixing docs to match the intended behavior of the code. > > Review from the maintainer (David) may help. > Thanks > > > -- Thanks, Anatoly