From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 3/4] doc: add mrvl net pmd documentation
Date: Wed, 4 Oct 2017 01:29:01 +0100
Message-ID: <fe780213-d122-3c13-ac5e-8dd21a5747b7@intel.com>
References: <1506594158-15721-2-git-send-email-tdu@semihalf.com>
 <1507031500-11473-1-git-send-email-tdu@semihalf.com>
 <1507031500-11473-4-git-send-email-tdu@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
 Jianbo.liu@linaro.org, Jacek Siuda <jck@semihalf.com>
To: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 56EAC1B5E8
 for <dev@dpdk.org>; Wed,  4 Oct 2017 02:29:03 +0200 (CEST)
In-Reply-To: <1507031500-11473-4-git-send-email-tdu@semihalf.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/3/2017 12:51 PM, Tomasz Duszynski wrote:
> Add documentation for the MRVL NET PMD driver.
> 
> Signed-off-by: Jacek Siuda <jck@semihalf.com>
> Signed-off-by: Tomasz Duszynski <jck@semihalf.com>

<...>

> +;
> +[Features]
> +Speed capabilities   = Y

This doesn't seems correct please check doc/guides/nics/features.rst

> +Link status          = Y
> +MTU update           = Y
> +Jumbo frame          = Y
> +Promiscuous mode     = Y
> +Allmulticast mode    = Y
> +Unicast MAC filter   = Y
> +Multicast MAC filter = Y
> +RSS hash             = Y
> +VLAN filter          = Y
> +CRC offload          = Y
> +L3 checksum offload  = Y
> +L4 checksum offload  = Y
> +Packet type parsing  = Y
> +Basic stats          = Y
> +Stats per queue      = Y
> +ARMv8                = Y

Is other architecture not supported or not tested?

> +Usage doc            = Y

<...>

> +Prerequisites
> +-------------
> +
> +- MUSDK (Marvell User-Space SDK) sources available
> +  `here <https://github.com/MarvellEmbeddedProcessors/musdk-marvell/tree/musdk-armada-17.08>`_.

Is this 17.08 by change related to DPDK version, I mean is there any
relation between DPDK version and musdk library version?

> +
> +    MUSDK is a light-weight library that provides direct access to Marvell's
> +    PPv2 (Packet Processor v2). Alternatively prebuilt MUSDK library can be
> +    requested from `Marvell Extranet <https://extranet.marvell.com>`_. Once
> +    approval has been granted, library can be found by typing ``musdk`` in
> +    search box.

What is the condition of having an approval?

> +
> +- DPDK environment
> +
> +    Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup
> +    DPDK environment.
> +
> +

<...>

> +Building DPDK
> +-------------
> +
> +Driver needs precompiled MUSDK library during compilation. Detailed build
> +process is described in library's documentation under ``doc`` directory.
> +
> +Before the DPDK build process the environmental variable ``LIBMUSDK_PATH`` with
> +the path to the MUSDK installation directory needs to be exported.
> +
> +Usage Example
> +-------------
> +
> +MRVL PMD requires extra kernel modules to function properly:
> +
> +.. code-block:: console
> +
> +   insmod musdk_uio.ko
> +   insmod mv_pp_uio.ko
> +   insmod mvpp2x_sysfs.ko

Why these kernel modules are required and how one can obtain them?
These are out of tree kernel modules right?

<...>