From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Green Subject: Re: [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated string Date: Sat, 12 May 2018 09:39:38 +0800 Message-ID: References: <152600304856.53146.9681482138854493833.stgit@localhost.localdomain> <152600320633.53146.1883908043976158624.stgit@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "stable@dpdk.org" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/11/2018 09:02 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green >> Sent: Friday, May 11, 2018 2:47 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated >> string >> >> Signed-off-by: Andy Green >> --- >> app/test-bbdev/test_bbdev_vector.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test- >> bbdev/test_bbdev_vector.c >> index c574f2135..4a3ddcffe 100644 >> --- a/app/test-bbdev/test_bbdev_vector.c >> +++ b/app/test-bbdev/test_bbdev_vector.c >> @@ -914,7 +914,8 @@ test_bbdev_vector_read(const char *filename, >> } >> >> entry = entry_extended; >> - strncat(entry, line, strlen(line)); >> + /* entry has been allocated accordingly */ >> + strcpy(&entry[strlen(entry)], line); > > If memset is removed in the previous patch, then we'll need to use strlcpy > here, to ensure NULL termination. No... the destination has been allocated dynamically so there is no case where the source length can exceed the destination. I think for that reason it's OK to remove the memset() here, because for the same reason it will always exactly fill the dynamically sized string anyway. -Andy > Missing fixes line and CC stable: > > Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") > Cc: stable@dpdk.org >