From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v2] compat: merge compat library into EAL Date: Thu, 10 Jan 2019 14:02:03 +0000 Message-ID: References: <20190110111104.56464-1-bruce.richardson@intel.com> <20190110134732.57052-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Marchand , Thomas Monjalon To: Bruce Richardson , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3D2E01B6C3 for ; Thu, 10 Jan 2019 15:02:06 +0100 (CET) In-Reply-To: <20190110134732.57052-1-bruce.richardson@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10-Jan-19 1:47 PM, Bruce Richardson wrote: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have any libs that are > built before EAL depend on it. Thankfully, this is not a major problem as > the only library which uses rte_compat.h and is built before EAL (kvargs) > already has the path to the compat.h header file explicitly called out as > an include path. > > However, to ensure that we don't later hit problems later with this, we can Also, later you might later want to fix it later when applying the patch later :) > add EAL common headers folder to the global include list in the meson build > which means that all common headers can be safely used by all libraries, no > matter what their build order. > > As a side-effect, this patch also fixes an issue with building on BSD using > meson, due to compat lib no longer needing to be listed as a dependency. > > Fixes: a8499f65a1d1 ("log: add missing experimental tag") > > Signed-off-by: Bruce Richardson > > --- -- Thanks, Anatoly