From mboxrd@z Thu Jan  1 00:00:00 1970
From: Balazs Nemeth <balazs.nemeth@intel.com>
Subject: [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors
Date: Mon, 20 Jul 2015 14:48:41 +0200
Message-ID: <hva9fv4jgfkm.fsf@intel.com>
References: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain
To: balazs.nemeth@intel.com,maryam.tahhan@intel.com,dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id F02E3C322
 for <dev@dpdk.org>; Mon, 20 Jul 2015 14:48:44 +0200 (CEST)
In-Reply-To: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove
> (rxnfgpc - hw_stats->gprc) which does not account for phy errors.
> hw_stats->gprc is the Number of good (non-erred) Rx packets (from the
> network) that pass L2 filtering and has a legal length as defined by
> LongPacketEnable. While rxnfgpc is the Number of good (non-erred with
> legal length) Rx packets (from the network) regardless of packet
> filtering and receive enablement. Thus hw_stats->gprc can be > rxnfgpc
> and this calculation should be removed from the calculation of ierrors.
> Validated with testpmd by sending packets to the interface without
> forwarding enabled - packets should be dropped and the error counters
> incremented.

> v2:
>  - specified the commit that this bug fix fixes

Acked-by: Balazs Nemeth <balazs.nemeth at intel.com>