* [PATCH v1 3/4] net/i40e: fix potential NULL dereference
From: Anatoly Burakov @ 2026-06-25 15:48 UTC (permalink / raw)
To: dev, Bruce Richardson
In-Reply-To: <c42d6f4efb83f4962ea096a702ed320a3d0a5eed.1782402484.git.anatoly.burakov@intel.com>
Static analysis reports that a rule dump may trigger NULL dereference when
rule pointer is NULL. This should not happen under normal circumstances as
0 sized rule would not dereference the rule data pointer due to chunking,
but it's a good defensive check, so add it.
Coverity issue: 503771
Fixes: ffaddd0fa935 ("net/i40e: support flow dump")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
drivers/net/intel/i40e/i40e_flow.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/net/intel/i40e/i40e_flow.c b/drivers/net/intel/i40e/i40e_flow.c
index 1051c99fba..142cfb5150 100644
--- a/drivers/net/intel/i40e/i40e_flow.c
+++ b/drivers/net/intel/i40e/i40e_flow.c
@@ -1276,11 +1276,19 @@ i40e_flow_dev_dump(struct rte_eth_dev *dev,
if (flow != NULL && p_flow != flow)
continue;
+ /* should not happen */
+ if (p_flow->rule == NULL) {
+ PMD_DRV_LOG(DEBUG, "Invalid flow rule");
+ continue;
+ }
+
+ rule_size = i40e_flow_rule_size(p_flow->filter_type);
+ /* should not happen either */
+ if (rule_size == 0)
+ continue;
+
found = true;
- if (p_flow->rule != NULL) {
- rule_size = i40e_flow_rule_size(p_flow->filter_type);
- rule_data = p_flow->rule;
- }
+ rule_data = p_flow->rule;
i40e_flow_dump_blob(file,
i40e_flow_rule_name(p_flow->filter_type),
rule_data, rule_size);
--
2.47.3
^ permalink raw reply related
* [PATCH v1 2/4] net/ixgbe: fix potential NULL dereference
From: Anatoly Burakov @ 2026-06-25 15:48 UTC (permalink / raw)
To: dev, Vladimir Medvedkin, Bruce Richardson
In-Reply-To: <c42d6f4efb83f4962ea096a702ed320a3d0a5eed.1782402484.git.anatoly.burakov@intel.com>
Static analysis reports that a rule dump may trigger NULL dereference. This
cannot actually happen because dump_blob will not dereference the rule_data
when rule_size is 0, but it's a good defensive check anyway, so add it.
Coverity issue: 503773
Fixes: 51f505a4090f ("net/ixgbe: support flow dump")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
drivers/net/intel/ixgbe/ixgbe_flow.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
index 19d7f93d93..6868893d46 100644
--- a/drivers/net/intel/ixgbe/ixgbe_flow.c
+++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
@@ -3345,11 +3345,18 @@ ixgbe_flow_dev_dump(struct rte_eth_dev *dev,
if (flow != NULL && p_flow != flow)
continue;
+ /* this should not happen */
+ if (p_flow->rule == NULL) {
+ PMD_DRV_LOG(DEBUG, "Invalid flow");
+ continue;
+ }
+
+ rule_size = ixgbe_flow_rule_size(p_flow);
+ if (rule_size == 0)
+ continue;
+
found = true;
- if (p_flow->rule != NULL) {
- rule_data = ixgbe_flow_rule_data(p_flow);
- rule_size = ixgbe_flow_rule_size(p_flow);
- }
+ rule_data = ixgbe_flow_rule_data(p_flow);
engine_name = ixgbe_flow_rule_engine_name(p_flow);
ixgbe_flow_dump_blob(file, engine_name,
rule_data, rule_size);
--
2.47.3
^ permalink raw reply related
* [PATCH v1 1/4] net/ice: fix potential NULL dereference
From: Anatoly Burakov @ 2026-06-25 15:48 UTC (permalink / raw)
To: dev, Bruce Richardson
Static analysis reports that a rule might have a valid engine but invalid
rule pointer while having a valid rule size. This should not happen in
normal operation, but it's a good defensive check, so fix the potential
issue by checking for the problematic condition before dumping flow memory.
Coverity issue: 503774
Fixes: 215a768c180a ("net/ice: support flow dump")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
drivers/net/intel/ice/ice_generic_flow.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/net/intel/ice/ice_generic_flow.c b/drivers/net/intel/ice/ice_generic_flow.c
index cbc3d78079..04097cca76 100644
--- a/drivers/net/intel/ice/ice_generic_flow.c
+++ b/drivers/net/intel/ice/ice_generic_flow.c
@@ -2660,15 +2660,18 @@ ice_flow_dev_dump(struct rte_eth_dev *dev,
if (flow != NULL && p_flow != flow)
continue;
+ /* this should not happen */
+ if (p_flow->engine == NULL || p_flow->rule == NULL) {
+ PMD_DRV_LOG(DEBUG, "Invalid flow");
+ continue;
+ }
+
found = true;
- if (p_flow->engine != NULL) {
- rule_size = p_flow->engine->rule_size;
- if (p_flow->rule != NULL)
- rule_data = p_flow->rule;
- }
- if (p_flow->engine != NULL)
- ice_flow_dump_blob(file,
+ rule_size = p_flow->engine->rule_size;
+ rule_data = p_flow->rule;
+
+ ice_flow_dump_blob(file,
p_flow->engine->name != NULL ?
p_flow->engine->name : "unknown",
rule_data, rule_size);
--
2.47.3
^ permalink raw reply related
* [PATCH v5] dts: report dut/NIC info during DTS run
From: Koushik Bhargav Nimoji @ 2026-06-25 15:47 UTC (permalink / raw)
To: luca.vizzarro, patrickrobb1997
Cc: dev, abailey, ahassick, lylavoie, Koushik Bhargav Nimoji
In-Reply-To: <20260602163647.101815-1-knimoji@iol.unh.edu>
This patch gathers NIC info during a DTS run and writes it to an output
json file. This allows the json file to be used when reporting results
on the DTS results dashboard.
Signed-off-by: Koushik Bhargav Nimoji <knimoji@iol.unh.edu>
---
v2:
*Resolved merge conflicts
v3:
*Fixed an issue with retrieving
the NIC's hardware version
v4:
*Moved nic info gathering step before the nics get
binded to their respective drivers
*Condensed some areas of code in order to make them
more readable
*Removed redundant None checks and added some where
required
*Fixed LshwOutput class to better reflect the lshw
command output
v5:
*Changed variable names for code readability
---
dts/framework/test_run.py | 10 +++
dts/framework/testbed_model/linux_session.py | 68 ++++++++++++++++++++
dts/framework/testbed_model/os_session.py | 11 ++++
3 files changed, 89 insertions(+)
diff --git a/dts/framework/test_run.py b/dts/framework/test_run.py
index 94dc6023a7..fea1b52e44 100644
--- a/dts/framework/test_run.py
+++ b/dts/framework/test_run.py
@@ -98,6 +98,7 @@
"InternalError" -> "exit":ew
"""
+import json
import random
from collections import deque
from collections.abc import Iterable
@@ -347,6 +348,14 @@ def next(self) -> State | None:
test_run.ctx.dpdk.setup()
test_run.ctx.topology.setup()
+ testrun_nic_info: list[dict[str, str]] = (
+ self.test_run.ctx.sut_node.main_session.get_nic_info()
+ )
+ with open(f"{SETTINGS.output_dir}/dut_info.json", "w") as file:
+ json.dump(testrun_nic_info, file, indent=3)
+
+ self.logger.info(f"DUT NIC info written to: {SETTINGS.output_dir}/dut_info.json")
+
if test_run.config.use_virtual_functions:
test_run.ctx.topology.instantiate_vf_ports()
if test_run.ctx.sut_node.cryptodevs and test_run.config.crypto:
@@ -370,6 +379,7 @@ def next(self) -> State | None:
test_run.supported_capabilities = get_supported_capabilities(
test_run.ctx.sut_node, test_run.ctx.topology, test_run.required_capabilities
)
+
return TestRunExecution(test_run, self.result)
def on_error(self, ex: BaseException) -> State | None:
diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py
index 3a6e97974b..b8836effbe 100644
--- a/dts/framework/testbed_model/linux_session.py
+++ b/dts/framework/testbed_model/linux_session.py
@@ -38,6 +38,8 @@ class LshwConfigurationOutput(TypedDict):
driver: str
#:
link: str
+ #:
+ firmware: str
class LshwOutput(TypedDict):
@@ -61,6 +63,12 @@ class LshwOutput(TypedDict):
...
"""
+ #:
+ vendor: NotRequired[str]
+ #:
+ product: NotRequired[str]
+ #:
+ version: NotRequired[str]
#:
businfo: str
#:
@@ -197,6 +205,66 @@ def unbind_ports(self, ports: list[Port]):
if self._lshw_net_info:
del self._lshw_net_info
+ def get_nic_info(self) -> list[dict[str, str]]:
+ """Overrides :meth`~.os_session.OSSession.get_nic_info`.
+
+ Raises:
+ ConfigurationError: If the NIC info could not be found.
+ """
+ port_data = {
+ port.get("businfo"): port for port in self._lshw_net_info if port.get("businfo")
+ }
+
+ all_nic_info: list[dict[str, str]] = []
+ for port in self._config.ports:
+ pci_addr = port.pci
+
+ lshw_result = self.send_command(
+ f"sudo lshw -c network -businfo | grep '{pci_addr}' | cut -d'@' -f1"
+ )
+ if lshw_result.return_code != 0 and lshw_result.stdout == "":
+ raise ConfigurationError(f"Unable to get bus type for port {pci_addr}.")
+ bus_type = lshw_result.stdout
+
+ bus_info = f"{bus_type}@{pci_addr}"
+ nic_port: LshwOutput | None = port_data[bus_info]
+ if nic_port is None:
+ raise ConfigurationError(f"Port {pci_addr} could not be found on the node.")
+
+ config: LshwConfigurationOutput | None = nic_port["configuration"]
+ if config is None:
+ raise ConfigurationError(
+ f"Configuration info for port {pci_addr} could not be found on the node."
+ )
+
+ if "logicalname" not in nic_port:
+ raise ConfigurationError(
+ f"Logical name for port {pci_addr} could not be found on the node."
+ )
+
+ ethtool_result = self.send_command(
+ f"ethtool {nic_port['logicalname']} | grep 'Speed:' | awk '{{print $2}}'"
+ )
+ if ethtool_result.return_code == 0 and ethtool_result.stdout:
+ nic_speed = ethtool_result.stdout
+ else:
+ self._logger.error(f"Unable to get speed for NIC: {pci_addr}")
+ nic_speed = None
+
+ dut_json = {
+ "make": nic_port["vendor"] if "vendor" in nic_port else "Unknown",
+ "model": nic_port["product"] if "product" in nic_port else "Unknown",
+ "hardware version": nic_port["version"] if "version" in nic_port else "Unknown",
+ "firmware version": config["firmware"] if "firmware" in config else "Unknown",
+ "deviceBusType": bus_type,
+ "deviceId": nic_port["serial"] if "serial" in nic_port else "Unknown",
+ "pmd": config["driver"] if "driver" in config else "Unknown",
+ "speed": nic_speed or "Unknown",
+ }
+ all_nic_info.append(dut_json)
+
+ return all_nic_info
+
def bind_ports_to_driver(self, ports: list[Port], driver_name: str) -> None:
"""Overrides :meth:`~.os_session.OSSession.bind_ports_to_driver`.
diff --git a/dts/framework/testbed_model/os_session.py b/dts/framework/testbed_model/os_session.py
index f2dc9b20a9..f88427a53d 100644
--- a/dts/framework/testbed_model/os_session.py
+++ b/dts/framework/testbed_model/os_session.py
@@ -581,6 +581,17 @@ def unbind_ports(self, ports: list[Port]) -> None:
ports: The list of ports to unbind.
"""
+ @abstractmethod
+ def get_nic_info(self) -> list[dict[str, str]]:
+ """Get NIC information.
+
+ Returns:
+ NIC info as a list of dictionaries.
+
+ Raises:
+ ConfigurationError: If the NIC info could not be found.
+ """
+
@abstractmethod
def bind_ports_to_driver(self, ports: list[Port], driver_name: str) -> None:
"""Bind `ports` to the given `driver_name`.
--
2.54.0
^ permalink raw reply related
* RE: [PATCH v5 4/9] bpf/arm64: mask shift count per RFC 9669
From: Marat Khalili @ 2026-06-25 15:40 UTC (permalink / raw)
To: Stephen Hemminger, dev@dpdk.org
Cc: stable@dpdk.org, Wathsala Vithanage, Konstantin Ananyev,
Jerin Jacob
In-Reply-To: <20260624175815.673064-5-stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday 24 June 2026 18:55
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; stable@dpdk.org; Wathsala Vithanage
> <wathsala.vithanage@arm.com>; Konstantin Ananyev <konstantin.ananyev@huawei.com>; Marat Khalili
> <marat.khalili@huawei.com>; Jerin Jacob <jerinj@marvell.com>
> Subject: [PATCH v5 4/9] bpf/arm64: mask shift count per RFC 9669
>
> The ARM JIT was not masking the shift count as required by RFC 9669
> (0x3f for 64-bit, 0x1f for 32-bit), so large immediate shift counts
> overflowed the UBFM/SBFM encoding and failed the JIT. Mask the
> immediate in emit_lsl/emit_lsr/emit_asr.
>
> Fixes: 9f4469d9e83a ("bpf/arm: add logical operations")
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Marat Khalili <marat.khalili@huawei.com>
> ---
> lib/bpf/bpf_jit_arm64.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/lib/bpf/bpf_jit_arm64.c b/lib/bpf/bpf_jit_arm64.c
> index ba7ae4d680..7582370062 100644
> --- a/lib/bpf/bpf_jit_arm64.c
> +++ b/lib/bpf/bpf_jit_arm64.c
> @@ -545,12 +545,14 @@ emit_bitfield(struct a64_jit_ctx *ctx, bool is64, uint8_t rd, uint8_t rn,
> emit_insn(ctx, insn, check_reg(rd) || check_reg(rn) ||
> check_immr_imms(is64, immr, imms));
> }
> +
> static void
> emit_lsl(struct a64_jit_ctx *ctx, bool is64, uint8_t rd, uint8_t imm)
> {
> const unsigned int width = is64 ? 64 : 32;
> uint8_t imms, immr;
>
> + imm &= width - 1;
> immr = (width - imm) & (width - 1);
> imms = width - 1 - imm;
>
> @@ -560,13 +562,19 @@ emit_lsl(struct a64_jit_ctx *ctx, bool is64, uint8_t rd, uint8_t imm)
> static void
> emit_lsr(struct a64_jit_ctx *ctx, bool is64, uint8_t rd, uint8_t imm)
> {
> - emit_bitfield(ctx, is64, rd, rd, imm, is64 ? 63 : 31, A64_UBFM);
> + const unsigned int width = is64 ? 64 : 32;
> +
> + imm &= width - 1;
> + emit_bitfield(ctx, is64, rd, rd, imm, width - 1, A64_UBFM);
> }
>
> static void
> emit_asr(struct a64_jit_ctx *ctx, bool is64, uint8_t rd, uint8_t imm)
> {
> - emit_bitfield(ctx, is64, rd, rd, imm, is64 ? 63 : 31, A64_SBFM);
> + const unsigned int width = is64 ? 64 : 32;
> +
> + imm &= width - 1;
> + emit_bitfield(ctx, is64, rd, rd, imm, width - 1, A64_SBFM);
> }
>
> #define A64_AND 0
> --
> 2.53.0
^ permalink raw reply
* RE: [PATCH v5 5/9] test/bpf: add test for large shift
From: Marat Khalili @ 2026-06-25 15:38 UTC (permalink / raw)
To: Stephen Hemminger, dev@dpdk.org; +Cc: Konstantin Ananyev
In-Reply-To: <20260624175815.673064-6-stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday 24 June 2026 18:55
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Konstantin Ananyev <konstantin.ananyev@huawei.com>;
> Marat Khalili <marat.khalili@huawei.com>
> Subject: [PATCH v5 5/9] test/bpf: add test for large shift
>
> There were multiple bugs with immediate values in shift instructions.
> The code was not masking as required by RFC.
>
> Add new tests that cover these instructions.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Marat Khalili <marat.khalili@huawei.com>
> ---
> app/test/test_bpf.c | 59 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
> diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c
> index 232e9e2a98..0e5894a532 100644
> --- a/app/test/test_bpf.c
> +++ b/app/test/test_bpf.c
> @@ -2005,6 +2005,51 @@ test_div1_check(uint64_t rc, const void *arg)
> return cmp_res(__func__, 0, rc, dve.out, dvt->out, sizeof(dve.out));
> }
>
> +/*
> + * Shift counts are masked to the operand width (RFC 9669: 0x3f for 64-bit,
> + * 0x1f for 32-bit). Counts >= 128 also exercise the x86 imm_size() path that
> + * used to desync the stream, and the arm64 UBFM/SBFM immediate encoding.
> + */
> +static const struct ebpf_insn test_shift_big_imm_prog[] = {
> + {
> + .code = (EBPF_ALU64 | EBPF_MOV | BPF_K),
> + .dst_reg = EBPF_REG_0,
> + .imm = 1
> + },
> + {
> + .code = (EBPF_ALU64 | BPF_LSH | BPF_K),
> + .dst_reg = EBPF_REG_0,
> + .imm = 191
> + },
> + {
> + .code = (EBPF_ALU64 | EBPF_ARSH | BPF_K),
> + .dst_reg = EBPF_REG_0,
> + .imm = 200
> + },
> + {
> + .code = (EBPF_ALU64 | BPF_RSH | BPF_K),
> + .dst_reg = EBPF_REG_0,
> + .imm = 130
> + },
> + {
> + .code = (BPF_JMP | EBPF_EXIT)
> + },
> +};
> +
> +static void
> +test_shift_big_imm_prepare(void *arg)
> +{
> + memset(arg, 0, sizeof(struct dummy_offset));
> +}
> +
> +static int
> +test_shift_big_imm_check(uint64_t rc, const void *arg)
> +{
> + uint64_t expect = 0x3FE0000000000000ULL;
> +
> + return cmp_res(__func__, expect, rc, arg, arg, 0);
> +}
> +
> /* call test-cases */
> static const struct ebpf_insn test_call1_prog[] = {
>
> @@ -3409,6 +3454,20 @@ static const struct bpf_test tests[] = {
> .prepare = test_mul1_prepare,
> .check_result = test_div1_check,
> },
> + {
> + .name = "test_shift_big_imm",
> + .arg_sz = sizeof(struct dummy_offset),
> + .prm = {
> + .ins = test_shift_big_imm_prog,
> + .nb_ins = RTE_DIM(test_shift_big_imm_prog),
> + .prog_arg = {
> + .type = RTE_BPF_ARG_PTR,
> + .size = sizeof(struct dummy_offset),
> + },
> + },
> + .prepare = test_shift_big_imm_prepare,
> + .check_result = test_shift_big_imm_check,
> + },
> {
> .name = "test_call1",
> .arg_sz = sizeof(struct dummy_offset),
> --
> 2.53.0
^ permalink raw reply
* RE: [PATCH v5 3/9] bpf: mask shift count in interpreter per RFC 9669
From: Marat Khalili @ 2026-06-25 15:35 UTC (permalink / raw)
To: Stephen Hemminger, dev@dpdk.org
Cc: stable@dpdk.org, Konstantin Ananyev, Ferruh Yigit
In-Reply-To: <20260624175815.673064-4-stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday 24 June 2026 18:55
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; stable@dpdk.org; Konstantin Ananyev
> <konstantin.ananyev@huawei.com>; Marat Khalili <marat.khalili@huawei.com>; Ferruh Yigit
> <ferruh.yigit@amd.com>
> Subject: [PATCH v5 3/9] bpf: mask shift count in interpreter per RFC 9669
>
> The interpreter shifted by the raw immediate or register value, which
> is undefined behavior in C when the count is >= the operand width and
> trips UBSan. RFC 9669 masks shift counts (0x3f for 64-bit, 0x1f for
> 32-bit); mask the count in the LSH/RSH/ARSH cases.
>
> Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework")
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Marat Khalili <marat.khalili@huawei.com>
> ---
> lib/bpf/bpf_exec.c | 31 +++++++++++++++++++++----------
> 1 file changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/lib/bpf/bpf_exec.c b/lib/bpf/bpf_exec.c
> index d423ef28f5..bb03c9cc2c 100644
> --- a/lib/bpf/bpf_exec.c
> +++ b/lib/bpf/bpf_exec.c
> @@ -4,6 +4,7 @@
>
> #include <stdio.h>
> #include <stdint.h>
> +#include <limits.h>
>
> #include <eal_export.h>
> #include <rte_common.h>
> @@ -43,6 +44,16 @@
> ((reg)[(ins)->dst_reg] = \
> (type)(reg)[(ins)->dst_reg] op (type)(ins)->imm)
>
> +#define BPF_OP_SHIFT_IMM(reg, ins, op, type) \
> + ((reg)[(ins)->dst_reg] = \
> + (type)(reg)[(ins)->dst_reg] op \
> + ((ins)->imm & (sizeof(type) * CHAR_BIT - 1)))
> +
> +#define BPF_OP_SHIFT_REG(reg, ins, op, type) \
> + ((reg)[(ins)->dst_reg] = \
> + (type)(reg)[(ins)->dst_reg] op \
> + ((reg)[(ins)->src_reg] & (sizeof(type) * CHAR_BIT - 1)))
> +
> #define BPF_DIV_ZERO_CHECK(bpf, reg, ins, type) do { \
> if ((type)(reg)[(ins)->src_reg] == 0) { \
> RTE_BPF_LOG_LINE(ERR, \
> @@ -183,10 +194,10 @@ bpf_exec(const struct rte_bpf *bpf, uint64_t reg[EBPF_REG_NUM])
> BPF_OP_ALU_IMM(reg, ins, |, uint32_t);
> break;
> case (BPF_ALU | BPF_LSH | BPF_K):
> - BPF_OP_ALU_IMM(reg, ins, <<, uint32_t);
> + BPF_OP_SHIFT_IMM(reg, ins, <<, uint32_t);
> break;
> case (BPF_ALU | BPF_RSH | BPF_K):
> - BPF_OP_ALU_IMM(reg, ins, >>, uint32_t);
> + BPF_OP_SHIFT_IMM(reg, ins, >>, uint32_t);
> break;
> case (BPF_ALU | BPF_XOR | BPF_K):
> BPF_OP_ALU_IMM(reg, ins, ^, uint32_t);
> @@ -217,10 +228,10 @@ bpf_exec(const struct rte_bpf *bpf, uint64_t reg[EBPF_REG_NUM])
> BPF_OP_ALU_REG(reg, ins, |, uint32_t);
> break;
> case (BPF_ALU | BPF_LSH | BPF_X):
> - BPF_OP_ALU_REG(reg, ins, <<, uint32_t);
> + BPF_OP_SHIFT_REG(reg, ins, <<, uint32_t);
> break;
> case (BPF_ALU | BPF_RSH | BPF_X):
> - BPF_OP_ALU_REG(reg, ins, >>, uint32_t);
> + BPF_OP_SHIFT_REG(reg, ins, >>, uint32_t);
> break;
> case (BPF_ALU | BPF_XOR | BPF_X):
> BPF_OP_ALU_REG(reg, ins, ^, uint32_t);
> @@ -262,13 +273,13 @@ bpf_exec(const struct rte_bpf *bpf, uint64_t reg[EBPF_REG_NUM])
> BPF_OP_ALU_IMM(reg, ins, |, uint64_t);
> break;
> case (EBPF_ALU64 | BPF_LSH | BPF_K):
> - BPF_OP_ALU_IMM(reg, ins, <<, uint64_t);
> + BPF_OP_SHIFT_IMM(reg, ins, <<, uint64_t);
> break;
> case (EBPF_ALU64 | BPF_RSH | BPF_K):
> - BPF_OP_ALU_IMM(reg, ins, >>, uint64_t);
> + BPF_OP_SHIFT_IMM(reg, ins, >>, uint64_t);
> break;
> case (EBPF_ALU64 | EBPF_ARSH | BPF_K):
> - BPF_OP_ALU_IMM(reg, ins, >>, int64_t);
> + BPF_OP_SHIFT_IMM(reg, ins, >>, int64_t);
> break;
> case (EBPF_ALU64 | BPF_XOR | BPF_K):
> BPF_OP_ALU_IMM(reg, ins, ^, uint64_t);
> @@ -299,13 +310,13 @@ bpf_exec(const struct rte_bpf *bpf, uint64_t reg[EBPF_REG_NUM])
> BPF_OP_ALU_REG(reg, ins, |, uint64_t);
> break;
> case (EBPF_ALU64 | BPF_LSH | BPF_X):
> - BPF_OP_ALU_REG(reg, ins, <<, uint64_t);
> + BPF_OP_SHIFT_REG(reg, ins, <<, uint64_t);
> break;
> case (EBPF_ALU64 | BPF_RSH | BPF_X):
> - BPF_OP_ALU_REG(reg, ins, >>, uint64_t);
> + BPF_OP_SHIFT_REG(reg, ins, >>, uint64_t);
> break;
> case (EBPF_ALU64 | EBPF_ARSH | BPF_X):
> - BPF_OP_ALU_REG(reg, ins, >>, int64_t);
> + BPF_OP_SHIFT_REG(reg, ins, >>, int64_t);
> break;
> case (EBPF_ALU64 | BPF_XOR | BPF_X):
> BPF_OP_ALU_REG(reg, ins, ^, uint64_t);
> --
> 2.53.0
^ permalink raw reply
* Re: [PATCH v4] dts: report dut/NIC info during DTS run
From: Koushik Bhargav Nimoji @ 2026-06-25 15:30 UTC (permalink / raw)
To: Patrick Robb; +Cc: luca.vizzarro, dev, abailey, ahassick, lylavoie
In-Reply-To: <CAK6DuxucO6-D0qTeTb=mdpWWP48j9rDyvbwfHGgjfwQXTM93Gg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 7237 bytes --]
On Wed, Jun 24, 2026 at 10:06 PM Patrick Robb <patrickrobb1997@gmail.com>
wrote:
>
>
> On Wed, Jun 24, 2026 at 5:33 PM Koushik Bhargav Nimoji <
> knimoji@iol.unh.edu> wrote:
>
>> This patch gathers NIC info during a DTS run and writes it to an output
>> json file. This allows the json file to be used when reporting results
>> on the DTS results dashboard.
>>
>> Signed-off-by: Koushik Bhargav Nimoji <knimoji@iol.unh.edu>
>> ---
>> v2:
>> *Resolved merge conflicts
>> v3:
>> *Fixed an issue with retrieving
>> the NIC's hardware version
>> v4:
>> *Moved nic info gathering step before the nics get
>> binded to their respective drivers
>> *Condensed some areas of code in order to make them
>> more readable
>> *Removed redundant None checks and added some where
>> required
>> *Fixed LshwOutput class to better reflect the lshw
>> command output
>> ---
>> dts/framework/test_run.py | 8 +++
>> dts/framework/testbed_model/linux_session.py | 68 ++++++++++++++++++++
>> dts/framework/testbed_model/os_session.py | 11 ++++
>> 3 files changed, 87 insertions(+)
>>
>> diff --git a/dts/framework/test_run.py b/dts/framework/test_run.py
>> index 94dc6023a7..c92fe90f2e 100644
>> --- a/dts/framework/test_run.py
>> +++ b/dts/framework/test_run.py
>> @@ -98,6 +98,7 @@
>> "InternalError" -> "exit":ew
>> """
>>
>> +import json
>> import random
>> from collections import deque
>> from collections.abc import Iterable
>> @@ -347,6 +348,12 @@ def next(self) -> State | None:
>> test_run.ctx.dpdk.setup()
>> test_run.ctx.topology.setup()
>>
>> + used_nic_info: list[dict[str, str]] =
>> self.test_run.ctx.sut_node.main_session.get_nic_info()
>>
>
> drop "used" for nic_info or change to testrun_nic_info?
>
>
>> + with open(f"{SETTINGS.output_dir}/dut_info.json", "w") as file:
>> + json.dump(used_nic_info, file, indent=3)
>> +
>> + self.logger.info(f"DUT NIC info written to:
>> {SETTINGS.output_dir}/dut_info.json")
>> +
>> if test_run.config.use_virtual_functions:
>> test_run.ctx.topology.instantiate_vf_ports()
>> if test_run.ctx.sut_node.cryptodevs and test_run.config.crypto:
>> @@ -370,6 +377,7 @@ def next(self) -> State | None:
>> test_run.supported_capabilities = get_supported_capabilities(
>> test_run.ctx.sut_node, test_run.ctx.topology,
>> test_run.required_capabilities
>> )
>> +
>> return TestRunExecution(test_run, self.result)
>>
>> def on_error(self, ex: BaseException) -> State | None:
>> diff --git a/dts/framework/testbed_model/linux_session.py
>> b/dts/framework/testbed_model/linux_session.py
>> index 3a6e97974b..9e9146c372 100644
>> --- a/dts/framework/testbed_model/linux_session.py
>> +++ b/dts/framework/testbed_model/linux_session.py
>> @@ -38,6 +38,8 @@ class LshwConfigurationOutput(TypedDict):
>> driver: str
>> #:
>> link: str
>> + #:
>> + firmware: str
>>
>>
>> class LshwOutput(TypedDict):
>> @@ -61,6 +63,12 @@ class LshwOutput(TypedDict):
>> ...
>> """
>>
>> + #:
>> + vendor: NotRequired[str]
>> + #:
>> + product: NotRequired[str]
>> + #:
>> + version: NotRequired[str]
>> #:
>> businfo: str
>> #:
>> @@ -197,6 +205,66 @@ def unbind_ports(self, ports: list[Port]):
>> if self._lshw_net_info:
>> del self._lshw_net_info
>>
>> + def get_nic_info(self) -> list[dict[str, str]]:
>> + """Overrides :meth`~.os_session.OSSession.get_nic_info`.
>> +
>> + Raises:
>> + ConfigurationError: If the NIC info could not be found.
>> + """
>> + port_data = {
>> + port.get("businfo"): port for port in self._lshw_net_info if
>> port.get("businfo")
>> + }
>> +
>> + all_nic_info: list[dict[str, str]] = []
>> + for port in self._config.ports:
>> + pci_addr = port.pci
>> +
>> + command_result = self.send_command(
>>
>
> rename to lshw_result please.
>
>
>> + f"sudo lshw -c network -businfo | grep '{pci_addr}' |
>> cut -d'@' -f1"
>> + )
>> + if command_result.return_code != 0 and command_result.stdout
>> == "":
>> + raise ConfigurationError(f"Unable to get bus type for
>> port {pci_addr}.")
>> + bus_type = command_result.stdout
>> +
>> + bus_info = f"{bus_type}@{pci_addr}"
>> + nic_port: LshwOutput | None = port_data[bus_info]
>> + if nic_port is None:
>> + raise ConfigurationError(f"Port {pci_addr} could not be
>> found on the node.")
>> +
>> + config: LshwConfigurationOutput | None =
>> nic_port["configuration"]
>> + if config is None:
>> + raise ConfigurationError(
>> + f"Configuration info for port {pci_addr} could not
>> be found on the node."
>> + )
>> +
>> + if "logicalname" not in nic_port:
>> + raise ConfigurationError(
>> + f"Logical name for port {pci_addr} could not be
>> found on the node."
>> + )
>> +
>> + command_result = self.send_command(
>>
>
> ethtool_result
>
>
>> + f"ethtool {nic_port['logicalname']} | grep 'Speed:' |
>> awk '{{print $2}}'"
>> + )
>
> + if command_result.return_code == 0 and command_result.stdout:
>> + nic_speed = command_result.stdout
>> + else:
>> + self._logger.error(f"Unable to get speed for NIC:
>> {pci_addr}")
>> + nic_speed = None
>> +
>> + dut_json = {
>> + "make": nic_port["vendor"] if "vendor" in nic_port else
>> "Unknown",
>> + "model": nic_port["product"] if "product" in nic_port
>> else "Unknown",
>> + "hardware version": nic_port["version"] if "version" in
>> nic_port else "Unknown",
>> + "firmware version": config["firmware"] if "firmware" in
>> config else "Unknown",
>> + "deviceBusType": bus_type,
>> + "deviceId": nic_port["serial"] if "serial" in nic_port
>> else "Unknown",
>> + "pmd": config["driver"] if "driver" in config else
>> "Unknown",
>> + "speed": nic_speed or "Unknown",
>> + }
>> + all_nic_info.append(dut_json)
>> +
>> + return all_nic_info
>> +
>>
>
> What is the intended behavior for cryptodev tests? I realize the ports
> list will be empty and we will not enter the initial loop, but is this
> intended? Do we want to gether cryptodev info too?
>
>
The intended behavior here is to skip cryptodev devices. Not entering the
initial loop, and therefore returning an empty list is the expected
behavior when running cryptodev tests.
>
> def bind_ports_to_driver(self, ports: list[Port], driver_name: str)
>> -> None:
>>
>>
> Reviewed-by: Patrick Robb <patrickrobb1997@gmail.com>
>
[-- Attachment #2: Type: text/html, Size: 10501 bytes --]
^ permalink raw reply
* Re: [PATCH v3 2/4] build: support function versioning for drivers
From: David Marchand @ 2026-06-25 14:45 UTC (permalink / raw)
To: Dariusz Sosnowski; +Cc: Bruce Richardson, dev, Yu Jiang
In-Reply-To: <20260625133311.1299705-3-dsosnowski@nvidia.com>
On Thu, 25 Jun 2026 at 15:34, Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
>
> Add support for enabling function versioning
> (through use_function_versioning meson variable) for drivers,
> similar to libraries.
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
> drivers/meson.build | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/meson.build b/drivers/meson.build
> index 4d95604ecd..8f3ab490ee 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -171,6 +171,7 @@ foreach subpath:subdirs
> pkgconfig_extra_libs = []
> testpmd_sources = []
> require_iova_in_mbuf = true
> + use_function_versioning = false
> # for handling base code files which may need extra cflags
> base_sources = []
> base_cflags = []
> @@ -273,6 +274,13 @@ foreach subpath:subdirs
> endif
> dpdk_conf.set(lib_name.to_upper(), 1)
>
> + if developer_mode and is_windows and use_function_versioning
> + message('@0@: Function versioning is not supported by Windows.'.format(name))
> + endif
> + if use_function_versioning
> + cflags += '-DRTE_USE_FUNCTION_VERSIONING'
> + endif
> +
> dpdk_extra_ldflags += pkgconfig_extra_libs
>
> dpdk_headers += headers
> @@ -363,7 +371,18 @@ foreach subpath:subdirs
> depends: [version_map])
> endif
>
> - shared_lib = shared_library(lib_name, sources_pmd_info,
> + if not use_function_versioning or is_windows
> + # Use pre-built objects and pmdinfo sources to build shared library.
> + shared_sources = sources_pmd_info
> + else
> + # For compat we need to rebuild with RTE_BUILD_SHARED_LIB defined.
> + # Use original sources and pmdinfo sources.
> + cflags += '-DRTE_BUILD_SHARED_LIB'
> + shared_sources = sources + sources_pmd_info
> + objs = []
> + endif
> +
> + shared_lib = shared_library(lib_name, shared_sources,
> objects: objs,
> include_directories: includes,
> dependencies: shared_deps,
Older meson version don't like this form:
drivers/meson.build:381:12: ERROR: Invalid use of addition: can only
concatenate list (not "CustomTargetHolder") to list
It seems to work with something like:
diff --git a/drivers/meson.build b/drivers/meson.build
index 8f3ab490ee..79c215a7c8 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -373,12 +373,12 @@ foreach subpath:subdirs
if not use_function_versioning or is_windows
# Use pre-built objects and pmdinfo sources to build
shared library.
- shared_sources = sources_pmd_info
+ shared_sources = [sources_pmd_info]
else
# For compat we need to rebuild with RTE_BUILD_SHARED_LIB defined.
# Use original sources and pmdinfo sources.
cflags += '-DRTE_BUILD_SHARED_LIB'
- shared_sources = sources + sources_pmd_info
+ shared_sources = sources + [sources_pmd_info]
objs = []
endif
--
David Marchand
^ permalink raw reply related
* RE: [PATCH v5 02/24] bpf: add format instruction function
From: Marat Khalili @ 2026-06-25 14:22 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Konstantin Ananyev, dev@dpdk.org
In-Reply-To: <20260624100934.00e99af1@phoenix.local>
> On Wed, 24 Jun 2026 13:17:35 +0100
> Marat Khalili <marat.khalili@huawei.com> wrote:
>
> > BPF library already contains BPF instruction formatting functions, but
> > they could only be used via `rte_bpf_dump` to dump result into file. Add
> > new function `rte_bpf_format` to format instruction in various way
> > (hexadecimal, disassembly) into a user-provided buffer, as well as a
> > service function `rte_bpf_insn_is_wide` to detect wide instructions.
> >
> > Signed-off-by: Marat Khalili <marat.khalili@huawei.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > ---
>
> Is this format similar to what tcpdump -d and objdump produce?
Closest I could find is bpf_dbg, the rest are slightly different.
Git log says it was originally added by you :)
^ permalink raw reply
* Re: [PATCH v1 2/2] dts: add latency coverage for cryptodev testing
From: Patrick Robb @ 2026-06-25 14:17 UTC (permalink / raw)
To: Andrew Bailey; +Cc: luca.vizzarro, dev, lylavoie, ahassick, knimoji
In-Reply-To: <20260513152715.133381-2-abailey@iol.unh.edu>
[-- Attachment #1: Type: text/plain, Size: 11431 bytes --]
On Wed, May 13, 2026 at 11:27 AM Andrew Bailey <abailey@iol.unh.edu> wrote:
> Currently, next DTS only has cryptodev testing coverage for throughput
> metrics. This patch adds a test suite to include latency testing for
> crypto devices.
>
> Signed-off-by: Andrew Bailey <abailey@iol.unh.edu>
> ---
> .../dts/tests.TestSuite_cryptodev_latency.rst | 8 +
> dts/tests/TestSuite_cryptodev_latency.py | 695 ++++++++++++++++++
> 2 files changed, 703 insertions(+)
> create mode 100644 doc/api/dts/tests.TestSuite_cryptodev_latency.rst
> create mode 100644 dts/tests/TestSuite_cryptodev_latency.py
>
>
> + @crypto_test
> + def aesni_gcm_vdev(self) -> None:
> + """aesni_gcm virtual device latency test.
> +
> + Steps:
> + * Create a cryptodev instance with provided device type and
> buffer sizes.
> + Verify:
> + * The latency is below or within delta of provided baseline.
> +
> + Raises:
> + SkippedTestException: When configuration is not provided.
> + """
> + if "aesni_gcm_vdev" not in self.latency_test_parameters:
> + skip("test not configured")
> + app = Cryptodev(
> + ptest=TestType.latency,
> + vdevs=[VirtualDevice("crypto_aesni_gcm0")],
> + devtype=DeviceType.crypto_aesni_gcm,
> + optype=OperationType.aead,
> + aead_op=EncryptDecryptSwitch.encrypt,
> + aead_key_sz=16,
> + aead_iv_sz=12,
> + aead_aad_sz=16,
> + digest_sz=16,
> + burst_sz=32,
> + total_ops=TOTAL_OPS,
> + buffer_sz=self.buffer_sizes["aesni_gcm_vdev"],
> + )
> + results = self._verify_latency(app.run_app(), "aesni_gcm_vdev")
> + self._print_stats(results)
> + for result in results:
> + verify(result["passed"] == "PASS", "latency fell more than
> the delta tolerance")
>
Why this one does not have "below baseline" in the string like other verify
assertions in this suite?
> +
> + @crypto_test
> + def aesni_mb_cipher_then_auth_vdev(self) -> None:
> + """aesni_mb vdev cipher and auth latency test.
> +
> + Steps:
> + * Create a cryptodev instance with provided device type and
> buffer sizes.
> + Verify:
> + * The latency is below or within delta of provided baseline.
> +
> + Raises:
> + SkippedTestException: When configuration is not provided.
> + """
> + if "aesni_mb_cipher_then_auth_vdev" not in
> self.latency_test_parameters:
> + skip("test not configured")
> + app = Cryptodev(
> + ptest=TestType.latency,
> + vdevs=[VirtualDevice("crypto_aesni_mb0")],
> + devtype=DeviceType.crypto_aesni_mb,
> + optype=OperationType.cipher_then_auth,
> + cipher_algo=CipherAlgorithm.aes_cbc,
> + cipher_op=EncryptDecryptSwitch.encrypt,
> + cipher_key_sz=16,
> + auth_algo=AuthenticationAlgorithm.sha1_hmac,
> + auth_op=AuthenticationOpMode.generate,
> + auth_key_sz=64,
> + digest_sz=12,
> + burst_sz=32,
> + total_ops=TOTAL_OPS,
> + buffer_sz=self.buffer_sizes["aesni_mb_cipher_then_auth_vdev"],
> + )
> + results = self._verify_latency(app.run_app(),
> "aesni_mb_cipher_then_auth_vdev")
> + self._print_stats(results)
> + for result in results:
> + verify(
> + result["passed"] == "PASS",
> + "latency fell more than the delta tolerance below
> baseline",
> + )
> +
> + @crypto_test
> + def aesni_mb_vdev(self) -> None:
> + """aesni_mb vdev latency test.
> +
> + Steps:
> + * Create a cryptodev instance with provided device type and
> buffer sizes.
> + Verify:
> + * The latency is below or within delta of provided baseline.
> +
> + Raises:
> + SkippedTestException: When configuration is not provided.
> + """
> + if "aesni_mb_vdev" not in self.latency_test_parameters:
> + skip("test not configured")
> + app = Cryptodev(
> + ptest=TestType.latency,
> + vdevs=[VirtualDevice("crypto_aesni_mb0")],
> + devtype=DeviceType.crypto_aesni_mb,
> + optype=OperationType.cipher_only,
> + cipher_algo=CipherAlgorithm.aes_cbc,
> + cipher_op=EncryptDecryptSwitch.encrypt,
> + cipher_key_sz=16,
> + cipher_iv_sz=16,
> + burst_sz=32,
> + total_ops=TOTAL_OPS,
> + buffer_sz=self.buffer_sizes["aesni_mb_vdev"],
> + )
> + results = self._verify_latency(app.run_app(), "aesni_mb_vdev")
> + self._print_stats(results)
> + for result in results:
> + verify(result["passed"] == "PASS", "Gbps fell below delta
> tolerance")
> +
> + @crypto_test
> + def kasumi_vdev(self) -> None:
> + """Kasumi vdev latency test.
> +
> + Steps:
> + * Create a cryptodev instance with provided device type and
> buffer sizes.
> + Verify:
> + * The latency is below or within delta of provided baseline.
> +
> + Raises:
> + SkippedTestException: When configuration is not provided.
> + """
> + if "kasumi_vdev" not in self.latency_test_parameters:
> + skip("test not configured")
> + app = Cryptodev(
> + ptest=TestType.latency,
> + vdevs=[VirtualDevice("crypto_kasumi0")],
> + devtype=DeviceType.crypto_kasumi,
> + optype=OperationType.cipher_then_auth,
> + cipher_algo=CipherAlgorithm.kasumi_f8,
> + cipher_op=EncryptDecryptSwitch.encrypt,
> + cipher_key_sz=16,
> + cipher_iv_sz=8,
> + auth_algo=AuthenticationAlgorithm.kasumi_f9,
> + auth_op=AuthenticationOpMode.generate,
> + auth_key_sz=16,
> + digest_sz=4,
> + burst_sz=32,
> + total_ops=TOTAL_OPS,
> + buffer_sz=self.buffer_sizes["kasumi_vdev"],
> + )
> + results = self._verify_latency(app.run_app(), "kasmui_vdev")
> + self._print_stats(results)
> + for result in results:
> + verify(result["passed"] == "PASS", "Gbps fell below delta
> tolerance")
>
Should this be latency instead of Gbps?
> +
> + @crypto_test
> + def open_ssl_vdev(self) -> None:
> + """open_ssl vdev latency test.
> +
> + Steps:
> + * Create a cryptodev instance with provided device type and
> buffer sizes.
> + Verify:
> + * The latency is below or within delta of provided baseline.
> +
> + Raises:
> + SkippedTestException: When configuration is not provided.
> + """
> + if "open_ssl_vdev" not in self.latency_test_parameters:
> + skip("test not configured")
> + app = Cryptodev(
> + ptest=TestType.latency,
> + vdevs=[VirtualDevice("crypto_openssl0")],
> + devtype=DeviceType.crypto_openssl,
> + optype=OperationType.aead,
> + aead_algo=AeadAlgName.aes_gcm,
> + aead_op=EncryptDecryptSwitch.encrypt,
> + aead_key_sz=16,
> + aead_iv_sz=16,
> + aead_aad_sz=16,
> + digest_sz=16,
> + total_ops=TOTAL_OPS,
> + buffer_sz=self.buffer_sizes["open_ssl_vdev"],
> + )
> + results = self._verify_latency(app.run_app(), "open_ssl_vdev")
> + self._print_stats(results)
> + for result in results:
> + verify(result["passed"] == "PASS", "Gbps fell below delta
> tolerance")
>
Same
> +
> + @crypto_test
> + def snow3g_vdev(self) -> None:
> + """snow3g vdev latency test.
> +
> + Steps:
> + * Create a cryptodev instance with provided device type and
> buffer sizes.
> + Verify:
> + * The latency is below or within delta of provided baseline.
> +
> + Raises:
> + SkippedTestException: When configuration is not provided.
> + """
> + if "snow3g_vdev" not in self.latency_test_parameters:
> + skip("test not configured")
> + app = Cryptodev(
> + ptest=TestType.latency,
> + vdevs=[VirtualDevice("crypto_snow3g0")],
> + devtype=DeviceType.crypto_snow3g,
> + optype=OperationType.cipher_then_auth,
> + cipher_algo=CipherAlgorithm.snow3g_uea2,
> + cipher_op=EncryptDecryptSwitch.encrypt,
> + cipher_key_sz=16,
> + cipher_iv_sz=16,
> + auth_algo=AuthenticationAlgorithm.snow3g_uia2,
> + auth_op=AuthenticationOpMode.generate,
> + auth_key_sz=16,
> + auth_iv_sz=16,
> + digest_sz=16,
> + burst_sz=32,
> + total_ops=TOTAL_OPS,
> + buffer_sz=self.buffer_sizes["open_ssl_vdev"],
> + )
> + results = self._verify_latency(app.run_app(), "open_ssl_vdev")
> + self._print_stats(results)
> + for result in results:
> + verify(result["passed"] == "PASS", "Gbps fell below delta
> tolerance")
>
Same
> +
> + @crypto_test
> + def zuc_vdev(self) -> None:
> + """Zuc vdev latency test.
> +
> + Steps:
> + * Create a cryptodev instance with provided device type and
> buffer sizes.
> + Verify:
> + * The latency is below or within delta of provided baseline.
> +
> + Raises:
> + SkippedTestException: When configuration is not provided.
> + """
> + if "zuc_vdev" not in self.latency_test_parameters:
> + skip("test not configured")
> + app = Cryptodev(
> + ptest=TestType.latency,
> + vdevs=[VirtualDevice("crypto_zuc0")],
> + devtype=DeviceType.crypto_zuc,
> + optype=OperationType.cipher_then_auth,
> + cipher_algo=CipherAlgorithm.zuc_eea3,
> + cipher_op=EncryptDecryptSwitch.encrypt,
> + cipher_key_sz=16,
> + cipher_iv_sz=16,
> + auth_algo=AuthenticationAlgorithm.zuc_eia3,
> + auth_op=AuthenticationOpMode.generate,
> + auth_key_sz=16,
> + auth_iv_sz=16,
> + digest_sz=4,
> + burst_sz=32,
> + total_ops=TOTAL_OPS,
> + buffer_sz=self.buffer_sizes["zuc_vdev"],
> + )
> + results = self._verify_latency(app.run_app(), "zuc_vdev")
> + self._print_stats(results)
> + for result in results:
> + verify(result["passed"] == "PASS", "Gbps fell below delta
> tolerance")
>
Same
> --
> 2.50.1
>
>
Make sure you also see the ai code review mention of kasumi and snow3g typo
or misassignment
https://mails.dpdk.org/archives/test-report/2026-May/990932.html
The suggestions about safety when reading index 0 of a list are worth
implementing too.
Reviewed-by: Patrick Robb <patrickrobb1997@gmail.com>
[-- Attachment #2: Type: text/html, Size: 15261 bytes --]
^ permalink raw reply
* [PATCH v6 6/6] eal: fix async IPC callback not fired when no peers
From: Anatoly Burakov @ 2026-06-25 14:01 UTC (permalink / raw)
To: dev, Jianfeng Tan
In-Reply-To: <cover.1782395581.git.anatoly.burakov@intel.com>
Currently, when rte_mp_request_async() is called and no peer processes
are connected (nb_sent == 0), the user callback is never invoked.
The original implementation used a dedicated background thread and
pthread_cond_signal() to wake it after queuing the dummy request. When
that thread was replaced with per-message alarms, no alarm was set for
the dummy request, silently breaking the nb_sent == 0 path.
This was not noticed because async requests are usually used while handling
secondary process requests, where peers are typically already present.
Fix it by setting a 1us alarm on the dummy request, so the callback path
immediately triggers and processes it.
Fixes: daf9bfca717e ("ipc: remove thread for async requests")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/common/eal_common_proc.c | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 235687ab84..2b8874e416 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -1197,11 +1197,22 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
ret = mp_request_async(eal_mp_socket_path(), copy, param, ts);
- /* if we didn't send anything, put dummy request on the queue */
+ /* if we didn't send anything, put dummy request on the queue
+ * and set a minimum-delay alarm so the callback fires immediately.
+ */
if (ret == 0 && reply->nb_sent == 0) {
TAILQ_INSERT_TAIL(&pending_requests.requests, dummy,
next);
dummy_used = true;
+ if (rte_eal_alarm_set(1, async_reply_handle,
+ (void *)(uintptr_t)dummy->id) < 0) {
+ EAL_LOG(ERR, "Fail to set alarm for dummy request");
+ /* roll back the changes */
+ TAILQ_REMOVE(&pending_requests.requests, dummy, next);
+ dummy_used = false;
+ ret = -1;
+ goto unlock_fail;
+ }
}
pthread_mutex_unlock(&pending_requests.lock);
@@ -1275,6 +1286,16 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
if (ret == 0 && reply->nb_sent == 0) {
TAILQ_INSERT_HEAD(&pending_requests.requests, dummy, next);
dummy_used = true;
+
+ if (rte_eal_alarm_set(1, async_reply_handle,
+ (void *)(uintptr_t)dummy->id) < 0) {
+ EAL_LOG(ERR, "Fail to set alarm for dummy request");
+ /* roll back the changes */
+ TAILQ_REMOVE(&pending_requests.requests, dummy, next);
+ dummy_used = false;
+ ret = -1;
+ goto closedir_fail;
+ }
}
/* finally, unlock the queue */
--
2.47.3
^ permalink raw reply related
* [PATCH v6 5/6] eal: fix memory leak in async IPC secondary path
From: Anatoly Burakov @ 2026-06-25 14:01 UTC (permalink / raw)
To: dev, Jianfeng Tan
In-Reply-To: <cover.1782395581.git.anatoly.burakov@intel.com>
When rte_mp_request_async() succeeds on the secondary process path, the
dummy request is freed only if it was inserted into the queue. However,
when the actual request was sent successfully (nb_sent > 0), the dummy is
not used and the function returns without freeing it.
Free dummy before returning on the success path when it was not inserted
into the queue.
Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/common/eal_common_proc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 5cd1bb8d13..235687ab84 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -1209,6 +1209,8 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
/* if we couldn't send anything, clean up */
if (ret != 0)
goto fail;
+ if (!dummy_used)
+ free(dummy);
return 0;
}
--
2.47.3
^ permalink raw reply related
* [PATCH v6 4/6] eal: fix async IPC memory leaks on partial failure
From: Anatoly Burakov @ 2026-06-25 14:01 UTC (permalink / raw)
To: dev, Jianfeng Tan
In-Reply-To: <cover.1782395581.git.anatoly.burakov@intel.com>
When rte_mp_request_async() fails to send requests to all peers,
copy and param can lose ownership and leak.
However, we cannot simply free them unconditionally, as "partial failure"
means some requests were already queued and thus still reference `copy` and
`param`, so freeing them directly on the error path can cause
use-after-free when those requests are later handled by the async timeout.
Fix this by rolling back queued requests from the current batch, and reset
nb_sent to 0. Freeing the requests is now safe even if some requests were
sent, as any responses or timeouts will not find the request ID in the
queue and will safely exit without doing anything.
Coverity issue: 501503
Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/common/eal_common_proc.c | 34 +++++++++++++++++++++++++++++++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 869ce99bf9..5cd1bb8d13 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -1242,7 +1242,34 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
} else if (mp_request_async(path, copy, param, ts))
ret = -1;
}
- /* if we didn't send anything, put dummy request on the queue */
+
+ /*
+ * On partial failure, roll back all queued requests. We hold the lock
+ * so no one else touches the queue. All requests in this batch share
+ * the same param pointer. Stale alarms will fire and harmlessly find
+ * nothing via ID-based lookup.
+ */
+ if (ret != 0 && reply->nb_sent > 0) {
+ struct pending_request *r, *next;
+
+ for (r = TAILQ_FIRST(&pending_requests.requests);
+ r != NULL; r = next) {
+ next = TAILQ_NEXT(r, next);
+ if (r->type == REQUEST_TYPE_ASYNC &&
+ r->async.param == param) {
+ TAILQ_REMOVE(&pending_requests.requests,
+ r, next);
+ free(r->reply);
+ /* r->request == copy, freed below after the loop */
+ free(r);
+ }
+ }
+ reply->nb_sent = 0;
+ }
+
+ /* if we didn't send anything, put dummy request on the queue
+ * and set a minimum-delay alarm so the callback fires immediately.
+ */
if (ret == 0 && reply->nb_sent == 0) {
TAILQ_INSERT_HEAD(&pending_requests.requests, dummy, next);
dummy_used = true;
@@ -1260,6 +1287,11 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
/* if dummy was unused, free it */
if (!dummy_used)
free(dummy);
+ /* if nothing was sent, nobody owns copy/param */
+ if (ret != 0) {
+ free(param);
+ free(copy);
+ }
return ret;
closedir_fail:
--
2.47.3
^ permalink raw reply related
* [PATCH v6 3/6] eal: avoid deadlock in async IPC alarm callback
From: Anatoly Burakov @ 2026-06-25 14:01 UTC (permalink / raw)
To: dev, Jianfeng Tan
In-Reply-To: <cover.1782395581.git.anatoly.burakov@intel.com>
async_reply_handle_thread_unsafe() can run while holding
pending_requests.lock and currently calls rte_eal_alarm_cancel().
rte_eal_alarm_cancel() may spin-wait for an executing callback, which can
deadlock if that callback is blocked on the same lock.
Remove callback-side alarm cancellation. It is safe to do so, because any
callback triggered without a pending request becomes a noop due to the
async request lookup now using numerical ID.
Fixes: daf9bfca717e ("ipc: remove thread for async requests")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/common/eal_common_proc.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 3e32ee5027..869ce99bf9 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -549,19 +549,6 @@ async_reply_handle_thread_unsafe(struct pending_request *req)
TAILQ_REMOVE(&pending_requests.requests, req, next);
- if (rte_eal_alarm_cancel(async_reply_handle,
- (void *)(uintptr_t)req->id) < 0) {
- /* if we failed to cancel the alarm because it's already in
- * progress, don't proceed because otherwise we will end up
- * handling the same message twice.
- */
- if (rte_errno == EINPROGRESS) {
- EAL_LOG(DEBUG, "Request handling is already in progress");
- goto no_trigger;
- }
- EAL_LOG(ERR, "Failed to cancel alarm");
- }
-
if (action == ACTION_TRIGGER)
return req;
no_trigger:
--
2.47.3
^ permalink raw reply related
* [PATCH v6 2/6] eal: use request ID instead of pointers
From: Anatoly Burakov @ 2026-06-25 14:01 UTC (permalink / raw)
To: dev, Jianfeng Tan
In-Reply-To: <cover.1782395581.git.anatoly.burakov@intel.com>
Initial implementation of async IPC request handling was using request
pointers directly. Because of the nature of how IPC is meant to work and
that requests ownership is disconnected from their creation (as in, freeing
a request may happen due to timeout, or due to received response, or due
to rollback because of a later failure), using pointers as identity is not
safe.
Use numeric request ID for async request lookup instead. This way, we can
safely free requests even if we are already waiting on responses/timeouts
for them, as the pointers themselves will not be referenced directly by
the response/timeout.
Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/common/eal_common_proc.c | 63 ++++++++++++++++++++++----------
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 799c6e81b0..3e32ee5027 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -74,6 +74,7 @@ struct async_request_param {
struct pending_request {
TAILQ_ENTRY(pending_request) next;
+ unsigned long id;
enum {
REQUEST_TYPE_SYNC,
REQUEST_TYPE_ASYNC
@@ -92,6 +93,8 @@ struct pending_request {
};
};
+static unsigned long next_request_id;
+
TAILQ_HEAD(pending_request_list, pending_request);
static struct {
@@ -111,15 +114,15 @@ mp_send(struct rte_mp_msg *msg, const char *peer, int type);
static void
async_reply_handle(void *arg);
-/* for use with process_msg */
+/* for use with alarm callback and process_msg */
static struct pending_request *
-async_reply_handle_thread_unsafe(void *arg);
+async_reply_handle_thread_unsafe(struct pending_request *req);
static void
trigger_async_action(struct pending_request *req);
static struct pending_request *
-find_pending_request(const char *dst, const char *act_name)
+find_request_by_name(const char *dst, const char *act_name)
{
struct pending_request *r;
@@ -132,6 +135,19 @@ find_pending_request(const char *dst, const char *act_name)
return r;
}
+static struct pending_request *
+find_async_request_by_id(unsigned long id)
+{
+ struct pending_request *r;
+
+ TAILQ_FOREACH(r, &pending_requests.requests, next) {
+ if (r->id == id && r->type == REQUEST_TYPE_ASYNC)
+ return r;
+ }
+
+ return NULL;
+}
+
/*
* Combine prefix and name(optional) to return unix domain socket path
* return the number of characters that would have been put into buffer.
@@ -354,7 +370,7 @@ process_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
struct pending_request *req = NULL;
pthread_mutex_lock(&pending_requests.lock);
- pending_req = find_pending_request(s->sun_path, msg->name);
+ pending_req = find_request_by_name(s->sun_path, msg->name);
if (pending_req) {
memcpy(pending_req->reply, msg, sizeof(*msg));
/* -1 indicates that we've been asked to ignore */
@@ -519,9 +535,8 @@ trigger_async_action(struct pending_request *sr)
}
static struct pending_request *
-async_reply_handle_thread_unsafe(void *arg)
+async_reply_handle_thread_unsafe(struct pending_request *req)
{
- struct pending_request *req = (struct pending_request *)arg;
enum async_action action;
struct timespec ts_now;
@@ -534,7 +549,8 @@ async_reply_handle_thread_unsafe(void *arg)
TAILQ_REMOVE(&pending_requests.requests, req, next);
- if (rte_eal_alarm_cancel(async_reply_handle, req) < 0) {
+ if (rte_eal_alarm_cancel(async_reply_handle,
+ (void *)(uintptr_t)req->id) < 0) {
/* if we failed to cancel the alarm because it's already in
* progress, don't proceed because otherwise we will end up
* handling the same message twice.
@@ -557,9 +573,13 @@ static void
async_reply_handle(void *arg)
{
struct pending_request *req;
+ /* alarm arg carries the request ID packed into a void * via uintptr_t */
+ unsigned long id = (uintptr_t)arg;
pthread_mutex_lock(&pending_requests.lock);
- req = async_reply_handle_thread_unsafe(arg);
+ req = find_async_request_by_id(id);
+ if (req != NULL)
+ req = async_reply_handle_thread_unsafe(req);
pthread_mutex_unlock(&pending_requests.lock);
if (req != NULL)
@@ -878,8 +898,19 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,
{
struct rte_mp_msg *reply_msg;
struct pending_request *pending_req, *exist;
+ unsigned long id;
int ret = -1;
+ /* queue already locked by caller */
+
+ exist = find_request_by_name(dst, req->name);
+ if (exist) {
+ EAL_LOG(ERR, "A pending request %s:%s", dst, req->name);
+ rte_errno = EEXIST;
+ return -1;
+ }
+
+ id = ++next_request_id;
pending_req = calloc(1, sizeof(*pending_req));
reply_msg = calloc(1, sizeof(*reply_msg));
if (pending_req == NULL || reply_msg == NULL) {
@@ -890,21 +921,12 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,
}
pending_req->type = REQUEST_TYPE_ASYNC;
+ pending_req->id = id;
strlcpy(pending_req->dst, dst, sizeof(pending_req->dst));
pending_req->request = req;
pending_req->reply = reply_msg;
pending_req->async.param = param;
- /* queue already locked by caller */
-
- exist = find_pending_request(dst, req->name);
- if (exist) {
- EAL_LOG(ERR, "A pending request %s:%s", dst, req->name);
- rte_errno = EEXIST;
- ret = -1;
- goto fail;
- }
-
ret = send_msg(dst, req, MP_REQ);
if (ret < 0) {
EAL_LOG(ERR, "Fail to send request %s:%s",
@@ -919,7 +941,7 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,
/* if alarm set fails, we simply ignore the reply */
if (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000,
- async_reply_handle, pending_req) < 0) {
+ async_reply_handle, (void *)(uintptr_t)id) < 0) {
EAL_LOG(ERR, "Fail to set alarm for request %s:%s",
dst, req->name);
ret = -1;
@@ -952,7 +974,7 @@ mp_request_sync(const char *dst, struct rte_mp_msg *req,
pthread_condattr_setclock(&attr, CLOCK_MONOTONIC);
pthread_cond_init(&pending_req.sync.cond, &attr);
- exist = find_pending_request(dst, req->name);
+ exist = find_request_by_name(dst, req->name);
if (exist) {
EAL_LOG(ERR, "A pending request %s:%s", dst, req->name);
rte_errno = EEXIST;
@@ -1178,6 +1200,7 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
* it, and put it on the queue if we don't send any requests.
*/
dummy->type = REQUEST_TYPE_ASYNC;
+ dummy->id = ++next_request_id;
dummy->request = copy;
dummy->reply = NULL;
dummy->async.param = param;
--
2.47.3
^ permalink raw reply related
* [PATCH v6 1/6] eal: fix wrong log message in async IPC request
From: Anatoly Burakov @ 2026-06-25 14:01 UTC (permalink / raw)
To: dev, Jianfeng Tan
In-Reply-To: <cover.1782395581.git.anatoly.burakov@intel.com>
The allocation failure log message in mp_request_async() says "sync
request" but the function handles asynchronous requests.
Fix the log to say "async request".
Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/common/eal_common_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 06f151818c..799c6e81b0 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -883,7 +883,7 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,
pending_req = calloc(1, sizeof(*pending_req));
reply_msg = calloc(1, sizeof(*reply_msg));
if (pending_req == NULL || reply_msg == NULL) {
- EAL_LOG(ERR, "Could not allocate space for sync request");
+ EAL_LOG(ERR, "Could not allocate space for async request");
rte_errno = ENOMEM;
ret = -1;
goto fail;
--
2.47.3
^ permalink raw reply related
* [PATCH v6 0/6] IPC fixes
From: Anatoly Burakov @ 2026-06-25 14:01 UTC (permalink / raw)
To: dev
In-Reply-To: <740b39c5098b4d40cafb9881ad70865a3c889012.1773936429.git.anatoly.burakov@intel.com>
Coverity has reported (issue ID 501503) a memory leak, but there
actually were a few more problems with IPC than that. This patchset
addresses said problems.
1. Using pointer as async request identity is unsafe
Because asynchronous requests can fail at arbitrary points while
having arbitrary number of requests or alarms already in flight,
using pointer as request identity can create use-after-free risks.
Patchset replaces this with using numeric request ID instead.
2. Alarm cancel can deadlock
Async request handler may attempt to cancel the alarm, but an alarm
might have already been in progress blocking on the same lock that
is held by async request, leading to a deadlock. Patchset removes
the alarm cancel call, and allows the alarm to fire. This is fine,
because due to fix #1 the worst that can happen from calling stale
alarm is a noop, as request ID would not be found.
3. Memory leaks
There are a couple of memory leaks in failure paths. Patchset fixes
those.
4. Zero-peer async request does not trigger alarm
When async requests are performed but no peers exist, we created
a dummy request and put it on the queue, but we never set the
dummy alarm that is supposed to handle that request. Patchset adds
the alarm set in dummy paths where none was present before.
v6:
Moved pieces around, namely:
1) apply request ID refactor first as a standalone patch
2) fix the deadlock immediately after
3) fix memory leaks next
4) add missing callback as a final step
Contents of the patchset remain the same.
Anatoly Burakov (6):
eal: fix wrong log message in async IPC request
eal: use request ID instead of pointers
eal: avoid deadlock in async IPC alarm callback
eal: fix async IPC memory leaks on partial failure
eal: fix memory leak in async IPC secondary path
eal: fix async IPC callback not fired when no peers
lib/eal/common/eal_common_proc.c | 133 +++++++++++++++++++++++--------
1 file changed, 99 insertions(+), 34 deletions(-)
--
2.47.3
^ permalink raw reply
* RE: [PATCH v5 7/9] bpf/arm64: add BPF_ABS/BPF_IND packet load support
From: Marat Khalili @ 2026-06-25 13:59 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Wathsala Vithanage, Konstantin Ananyev, dev@dpdk.org
In-Reply-To: <20260624175815.673064-8-stephen@networkplumber.org>
Below is what gdb shows actually generated for instruction 15 of
test_ld_mbuf1_prog (with minimal changes and comments for readability). I
suggest adding this to the comments or (if we don't feel like keeping it
updated) the commit message, it helps analyzing the code a bit.
(Also, stack drawings in the file do not include the buffer we use here.)
0: 0x92800069 mov x9, #-4 // mov x9, <imm>
1: 0x8b150129 add x9, x9, x21 // add x9, src_reg
2: 0xd280050a mov x10, #40 // mov x9, <&::data_len>
3: 0x786a6a6a ldrh w10, [x19, x10]
4: 0xcb09014a sub x10, x10, x9
5: 0xd280008b mov x11, #4 // mov x11, <sz>
6: 0xeb0b014f subs x15, x10, x11
7: 0x5400010b b.lt +8 // b.lt slow
8: 0xd280020a mov x10, #16 // mov x10, <&::data_off>
9: 0x786a6a6a ldrh w10, [x19, x10]
10: 0xd2800007 mov x7, #0 // mov x7, <&::buf_addr>
11: 0xf8676a67 ldr x7, [x19, x7]
12: 0x8b0a00e7 add x7, x7, x10
13: 0x8b0900e7 add x7, x7, x9
14: 0x1400000c b +12 // b load
slow:
15: 0x91000121 add x1, x9, #0 // mov x1, x9
16: 0x91000260 add x0, x19, #0 // mov x0, x19
17: 0x52800082 mov w2, #4 // mov w2, <sz>
18: 0xd1002323 sub x3, x25, #8 // sub x3, x25, <stack_ofs>
19: 0xd2a04d49 mov x9, #0x26a0000 // mov x9,
20: 0xf29d3409 movk x9, #0xe9a0 // __rte_pktmbuf_read
21: 0xd63f0120 blr x9
22: 0x91000007 add x7, x0, #0 // mov x7, x0
23: 0xb5000067 cbnz x7, +3 // cbnz load
24: 0xd2800007 mov x7, #0x0
25: 0x17ffff88 b -120 // b epilogue
load:
26: 0xb87f68e7 ldr w7, [x7, xzr]
27: 0xdac008e7 rev32 x7, x7
Opcode variations:
* Instruction 1 is omitted for BPF_ABS.
* Instruction 26 varies depending on sz.
* Instruction 27 varies or is omitted depending on sz.
Some benign nits:
* Instruction 6 should probably be `subs xzr, x10, x11`, a slight 1-bit error in
the existing code, though x15 is unused.
* Instructions 5 and 17 use different encoding for the same operation, would be
nice to keep them consistent, though operand never exceeds INT32_MAX.
* Instruction 10 is redundant.
I see two problems:
* We never check that x9 is non-negative. We could either add one more check,
or rearrange the code and use unsigned comparison at 7: (currently b.lt).
(There was some discussion previously regarding the special meaning of
negative BPF_ABS immediate, but I believe this is out of scope of this patch,
here we should just fail on negative _effective_ offset regardless of opcode.)
* Second argument of __rte_pktmbuf_read is `uint32_t off`, and we are trying to
pass 64-bit offset in x1. We need a check that it does not exceed UINT32_MAX.
Otherwise looks good to me.
^ permalink raw reply
* [PATCH v3 4/4] ethdev: fix promoted flow metadata symbols
From: Dariusz Sosnowski @ 2026-06-25 13:33 UTC (permalink / raw)
To: David Marchand, Bruce Richardson, Thomas Monjalon,
Andrew Rybchenko, Ori Kam
Cc: dev, Yu Jiang
In-Reply-To: <20260625133311.1299705-1-dsosnowski@nvidia.com>
Offending commit stabilized the following symbols
related to flow metadata:
- 1 function symbol:
- rte_flow_dynf_metadata_register
- 2 variable symbols:
- rte_flow_dynf_metadata_offs
- rte_flow_dynf_metadata_mask
Any application using experimental flow metadata symbols,
which was linked dynamically against 25.11 version of ethdev
library and using current version of ethdev library
would fail to start on symbol lookup error:
/tmp/dpdk-25.11/usr/local/bin/dpdk-testpmd:
symbol lookup error: /tmp/dpdk-25.11/usr/local/bin/dpdk-testpmd:
undefined symbol: rte_flow_dynf_metadata_offs, version EXPERIMENTAL
This patch addresses that issue by restoring EXPERIMENTAL version
on the global variables to keep ABI compatibility [1].
Related inline helpers and variable declarations are kept as stable
(i.e., no __rte_experimental marker).
EXPERIMENTAL version will be removed from these global variables
in 26.11 release cycle on next ABI version bump.
Standard function symbol versioning is also applied on
rte_flow_dynf_metadata_register() function.
[1]: https://inbox.dpdk.org/dev/m7s3jl2566kibbapr2mfa2ic2opuc6b4ok2g67j3il5dgduzih@cz5wcdstb75n/
Bugzilla ID: 1957
Fixes: 4ee2f5c1cedf ("ethdev: promote flow metadata API to stable")
Reported-by: Yu Jiang <yux.jiang@intel.com>
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Acked-by: David Marchand <david.marchand@redhat.com>
---
lib/ethdev/meson.build | 2 ++
lib/ethdev/rte_flow.c | 13 ++++++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build
index 8ba6c708a2..63fd866af9 100644
--- a/lib/ethdev/meson.build
+++ b/lib/ethdev/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+use_function_versioning = true
+
sources = files(
'ethdev_driver.c',
'ethdev_private.c',
diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
index ec0fe08355..24eb5a95b0 100644
--- a/lib/ethdev/rte_flow.c
+++ b/lib/ethdev/rte_flow.c
@@ -23,11 +23,11 @@
#define FLOW_LOG RTE_ETHDEV_LOG_LINE
/* Mbuf dynamic field name for metadata. */
-RTE_EXPORT_SYMBOL(rte_flow_dynf_metadata_offs)
+RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_flow_dynf_metadata_offs, 19.11)
int32_t rte_flow_dynf_metadata_offs = -1;
/* Mbuf dynamic field flag bit number for metadata. */
-RTE_EXPORT_SYMBOL(rte_flow_dynf_metadata_mask)
+RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_flow_dynf_metadata_mask, 19.11)
uint64_t rte_flow_dynf_metadata_mask;
/**
@@ -281,9 +281,7 @@ static const struct rte_flow_desc_data rte_flow_desc_action[] = {
MK_FLOW_ACTION(JUMP_TO_TABLE_INDEX, sizeof(struct rte_flow_action_jump_to_table_index)),
};
-RTE_EXPORT_SYMBOL(rte_flow_dynf_metadata_register)
-int
-rte_flow_dynf_metadata_register(void)
+RTE_DEFAULT_SYMBOL(26, int, rte_flow_dynf_metadata_register, (void))
{
int offset;
int flag;
@@ -316,6 +314,11 @@ rte_flow_dynf_metadata_register(void)
return -rte_errno;
}
+RTE_VERSION_EXPERIMENTAL_SYMBOL(int, rte_flow_dynf_metadata_register, (void))
+{
+ return rte_flow_dynf_metadata_register();
+}
+
static inline void
fts_enter(struct rte_eth_dev *dev)
{
--
2.47.3
^ permalink raw reply related
* [PATCH v3 3/4] net/mlx5: fix stabilized function versions
From: Dariusz Sosnowski @ 2026-06-25 13:33 UTC (permalink / raw)
To: David Marchand, Bruce Richardson, Viacheslav Ovsiienko, Bing Zhao,
Ori Kam, Suanming Mou, Matan Azrad
Cc: dev, Yu Jiang
In-Reply-To: <20260625133311.1299705-1-dsosnowski@nvidia.com>
Offending patch stabilized the following function symbols:
- rte_pmd_mlx5_driver_event_cb_register
- rte_pmd_mlx5_driver_event_cb_unregister
- rte_pmd_mlx5_enable_steering
- rte_pmd_mlx5_disable_steering
These function symbols were introduced in 25.11.
Any application using these functions, linked against 25.11 version,
would fail when used with 26.07 libraries, because only DPDK_26 versions
of these symbols were exported.
This patch fixes that by adding proper function symbol versioning
to these symbols.
Fixes: e8cab133645f ("net/mlx5: promote some private API to stable")
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Acked-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/mlx5/meson.build | 2 ++
drivers/net/mlx5/mlx5_driver_event.c | 22 ++++++++++++++++------
drivers/net/mlx5/mlx5_flow.c | 18 ++++++++++++------
3 files changed, 30 insertions(+), 12 deletions(-)
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 82a7dfe782..0fa6322779 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -2,6 +2,8 @@
# Copyright 2018 6WIND S.A.
# Copyright 2018 Mellanox Technologies, Ltd
+use_function_versioning = true
+
if not (is_linux or is_windows)
build = false
reason = 'only supported on Linux and Windows'
diff --git a/drivers/net/mlx5/mlx5_driver_event.c b/drivers/net/mlx5/mlx5_driver_event.c
index 89e49331c8..d0e22d6151 100644
--- a/drivers/net/mlx5/mlx5_driver_event.c
+++ b/drivers/net/mlx5/mlx5_driver_event.c
@@ -236,9 +236,8 @@ notify_existing_devices(rte_pmd_mlx5_driver_event_callback_t cb, void *opaque)
notify_existing_queues(port_id, cb, opaque);
}
-RTE_EXPORT_SYMBOL(rte_pmd_mlx5_driver_event_cb_register)
-int
-rte_pmd_mlx5_driver_event_cb_register(rte_pmd_mlx5_driver_event_callback_t cb, void *opaque)
+RTE_DEFAULT_SYMBOL(26, int, rte_pmd_mlx5_driver_event_cb_register,
+ (rte_pmd_mlx5_driver_event_callback_t cb, void *opaque))
{
struct registered_cb *r;
@@ -264,9 +263,14 @@ rte_pmd_mlx5_driver_event_cb_register(rte_pmd_mlx5_driver_event_callback_t cb, v
return 0;
}
-RTE_EXPORT_SYMBOL(rte_pmd_mlx5_driver_event_cb_unregister)
-int
-rte_pmd_mlx5_driver_event_cb_unregister(rte_pmd_mlx5_driver_event_callback_t cb)
+RTE_VERSION_EXPERIMENTAL_SYMBOL(int, rte_pmd_mlx5_driver_event_cb_register,
+ (rte_pmd_mlx5_driver_event_callback_t cb, void *opaque))
+{
+ return rte_pmd_mlx5_driver_event_cb_register(cb, opaque);
+}
+
+RTE_DEFAULT_SYMBOL(26, int, rte_pmd_mlx5_driver_event_cb_unregister,
+ (rte_pmd_mlx5_driver_event_callback_t cb))
{
struct registered_cb *r;
bool found = false;
@@ -289,6 +293,12 @@ rte_pmd_mlx5_driver_event_cb_unregister(rte_pmd_mlx5_driver_event_callback_t cb)
return 0;
}
+RTE_VERSION_EXPERIMENTAL_SYMBOL(int, rte_pmd_mlx5_driver_event_cb_unregister,
+ (rte_pmd_mlx5_driver_event_callback_t cb))
+{
+ return rte_pmd_mlx5_driver_event_cb_unregister(cb);
+}
+
RTE_FINI(rte_pmd_mlx5_driver_event_cb_cleanup) {
struct registered_cb *r;
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index a95dd9dc94..4b984df892 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -12506,9 +12506,7 @@ flow_disable_steering_run_on_related(struct rte_eth_dev *dev,
}
}
-RTE_EXPORT_SYMBOL(rte_pmd_mlx5_disable_steering)
-void
-rte_pmd_mlx5_disable_steering(void)
+RTE_DEFAULT_SYMBOL(26, void, rte_pmd_mlx5_disable_steering, (void))
{
uint16_t port_id;
@@ -12532,9 +12530,12 @@ rte_pmd_mlx5_disable_steering(void)
mlx5_steering_disabled = true;
}
-RTE_EXPORT_SYMBOL(rte_pmd_mlx5_enable_steering)
-int
-rte_pmd_mlx5_enable_steering(void)
+RTE_VERSION_EXPERIMENTAL_SYMBOL(void, rte_pmd_mlx5_disable_steering, (void))
+{
+ rte_pmd_mlx5_disable_steering();
+}
+
+RTE_DEFAULT_SYMBOL(26, int, rte_pmd_mlx5_enable_steering, (void))
{
uint16_t port_id;
@@ -12551,6 +12552,11 @@ rte_pmd_mlx5_enable_steering(void)
return 0;
}
+RTE_VERSION_EXPERIMENTAL_SYMBOL(int, rte_pmd_mlx5_enable_steering, (void))
+{
+ return rte_pmd_mlx5_enable_steering();
+}
+
bool
mlx5_vport_rx_metadata_passing_enabled(const struct mlx5_dev_ctx_shared *sh)
{
--
2.47.3
^ permalink raw reply related
* [PATCH v3 2/4] build: support function versioning for drivers
From: Dariusz Sosnowski @ 2026-06-25 13:33 UTC (permalink / raw)
To: David Marchand, Bruce Richardson; +Cc: dev, Yu Jiang
In-Reply-To: <20260625133311.1299705-1-dsosnowski@nvidia.com>
Add support for enabling function versioning
(through use_function_versioning meson variable) for drivers,
similar to libraries.
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
drivers/meson.build | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index 4d95604ecd..8f3ab490ee 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -171,6 +171,7 @@ foreach subpath:subdirs
pkgconfig_extra_libs = []
testpmd_sources = []
require_iova_in_mbuf = true
+ use_function_versioning = false
# for handling base code files which may need extra cflags
base_sources = []
base_cflags = []
@@ -273,6 +274,13 @@ foreach subpath:subdirs
endif
dpdk_conf.set(lib_name.to_upper(), 1)
+ if developer_mode and is_windows and use_function_versioning
+ message('@0@: Function versioning is not supported by Windows.'.format(name))
+ endif
+ if use_function_versioning
+ cflags += '-DRTE_USE_FUNCTION_VERSIONING'
+ endif
+
dpdk_extra_ldflags += pkgconfig_extra_libs
dpdk_headers += headers
@@ -363,7 +371,18 @@ foreach subpath:subdirs
depends: [version_map])
endif
- shared_lib = shared_library(lib_name, sources_pmd_info,
+ if not use_function_versioning or is_windows
+ # Use pre-built objects and pmdinfo sources to build shared library.
+ shared_sources = sources_pmd_info
+ else
+ # For compat we need to rebuild with RTE_BUILD_SHARED_LIB defined.
+ # Use original sources and pmdinfo sources.
+ cflags += '-DRTE_BUILD_SHARED_LIB'
+ shared_sources = sources + sources_pmd_info
+ objs = []
+ endif
+
+ shared_lib = shared_library(lib_name, shared_sources,
objects: objs,
include_directories: includes,
dependencies: shared_deps,
--
2.47.3
^ permalink raw reply related
* [PATCH v3 1/4] eal: fix macro for versioned experimental symbol
From: Dariusz Sosnowski @ 2026-06-25 13:33 UTC (permalink / raw)
To: David Marchand, Bruce Richardson; +Cc: dev, Yu Jiang
In-Reply-To: <20260625133311.1299705-1-dsosnowski@nvidia.com>
Add a missing semicolon after __asm__ block in
RTE_VERSION_EXPERIMENTAL_SYMBOL macro.
It's lack triggers the following compilation error with clang:
../lib/ethdev/rte_flow.c:320:1: error: expected ';' after top-level asm block
320 | RTE_VERSION_EXPERIMENTAL_SYMBOL(int, rte_flow_dynf_metadata_register, (void))
| ^
../lib/eal/common/eal_export.h:75:74: note: expanded from macro 'RTE_VERSION_EXPERIMENTAL_SYMBOL'
75 | __asm__(".symver " RTE_STR(name) "_exp, " RTE_STR(name) "@EXPERIMENTAL") \
| ^
../lib/eal/include/rte_common.h:237:20: note: expanded from macro '\
__rte_used'
237 | #define __rte_used __attribute__((used))
| ^
Fixes: e30e194c4d06 ("eal: rework function versioning macros")
Cc: david.marchand@redhat.com
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
---
lib/eal/common/eal_export.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_export.h b/lib/eal/common/eal_export.h
index 888fd9f9ed..7971bf8d7a 100644
--- a/lib/eal/common/eal_export.h
+++ b/lib/eal/common/eal_export.h
@@ -72,7 +72,7 @@ __rte_used type name ## _v ## ver args; \
type name ## _v ## ver args
#define RTE_VERSION_EXPERIMENTAL_SYMBOL(type, name, args) VERSIONING_WARN \
-__asm__(".symver " RTE_STR(name) "_exp, " RTE_STR(name) "@EXPERIMENTAL") \
+__asm__(".symver " RTE_STR(name) "_exp, " RTE_STR(name) "@EXPERIMENTAL"); \
__rte_used type name ## _exp args; \
type name ## _exp args
--
2.47.3
^ permalink raw reply related
* [PATCH v3 0/4] add versioned symbols for recently stabilized APIs
From: Dariusz Sosnowski @ 2026-06-25 13:33 UTC (permalink / raw)
To: David Marchand, Bruce Richardson, Thomas Monjalon,
Andrew Rybchenko, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Suanming Mou, Matan Azrad
Cc: dev, Yu Jiang
In-Reply-To: <20260624131337.1127323-1-dsosnowski@nvidia.com>
Main goal of this patchset is to address https://bugs.dpdk.org/show_bug.cgi?id=1957
but it also handles other recently stabilized symbols and has some minor fixes:
- Patch 1 - Fix RTE_VERSION_EXPERIMENTAL_SYMBOL macro on clang.
- Patch 2 - Allow function versioning inside drivers.
- Patch 3 - Version the function symbols stabilized in
https://git.dpdk.org/dpdk/commit/?id=e8cab133645f5466ef75e511629add43b68a5027
- Patch 4 - Version the rte_flow_dynf_metadata_register() function stabilized in
https://git.dpdk.org/dpdk/commit/?id=4ee2f5c1cedf9ee7f39afa667f71b07f4004ba5c
Restore EXPERIMENTAL version on global variable symbols
rte_flow_dynf_metadata_offs and rte_flow_dynf_metadata_mask.
v3:
- Added rebuilding of drivers with -DRTE_BUILD_SHARED_LIB
whenever function versioning is enabled.
v2:
- https://inbox.dpdk.org/dev/20260624131337.1127323-1-dsosnowski@nvidia.com/
- Drop patches introducing versioning macros for symbol aliases
and their usage (patch 4 and 5 from v1)
- EXPERIMENTAL version on global variable symbols
rte_flow_dynf_metadata_offs and rte_flow_dynf_metadata_mask,
as discussed under v1.
- Change commit title prefix in patch (2) from "drivers" to "build".
v1: https://inbox.dpdk.org/dev/20260623113752.1100072-1-dsosnowski@nvidia.com/
Dariusz Sosnowski (4):
eal: fix macro for versioned experimental symbol
build: support function versioning for drivers
net/mlx5: fix stabilized function versions
ethdev: fix promoted flow metadata symbols
drivers/meson.build | 21 ++++++++++++++++++++-
drivers/net/mlx5/meson.build | 2 ++
drivers/net/mlx5/mlx5_driver_event.c | 22 ++++++++++++++++------
drivers/net/mlx5/mlx5_flow.c | 18 ++++++++++++------
lib/eal/common/eal_export.h | 2 +-
lib/ethdev/meson.build | 2 ++
lib/ethdev/rte_flow.c | 13 ++++++++-----
7 files changed, 61 insertions(+), 19 deletions(-)
--
2.47.3
^ permalink raw reply
* [PATCH v8 23/23] net/sxe2: update sxe2 feature matrix docs
From: liujie5 @ 2026-06-25 13:31 UTC (permalink / raw)
To: stephen; +Cc: dev, Jie Liu
In-Reply-To: <20260625055021.63243-1-liujie5@linkdatatechnology.com>
From: Jie Liu <liujie5@linkdatatechnology.com>
Update the sxe2.ini feature sheet to accurately reflect the recently
implemented hardware capabilities in the sxe2 PMD.
Signed-off-by: Jie Liu <liujie5@linkdatatechnology.com>
---
doc/guides/nics/features/sxe2.ini | 56 ++++++++++
doc/guides/nics/sxe2.rst | 168 ++++++++++++++++++++++++++++++
2 files changed, 224 insertions(+)
diff --git a/doc/guides/nics/features/sxe2.ini b/doc/guides/nics/features/sxe2.ini
index 09ba2f558c..3c1e6a8a39 100644
--- a/doc/guides/nics/features/sxe2.ini
+++ b/doc/guides/nics/features/sxe2.ini
@@ -7,17 +7,73 @@
; is selected.
;
[Features]
+Speed capabilities = Y
+Link status = Y
+Link status event = Y
+Rx interrupt = Y
Fast mbuf free = P
Free Tx mbuf on demand = Y
Burst mode info = Y
Queue start/stop = Y
+Power mgmt address monitor = Y
Buffer split on Rx = P
Scattered Rx = Y
+Traffic manager = Y
CRC offload = Y
+VLAN offload = Y
+QinQ offload = P
L3 checksum offload = Y
L4 checksum offload = Y
+Timestamp offload = P
+Inner L3 checksum = P
+Inner L4 checksum = P
Rx descriptor status = Y
Tx descriptor status = Y
+MTU update = Y
+TSO = P
+Promiscuous mode = Y
+Allmulticast mode = Y
+Unicast MAC filter = Y
+RSS hash = Y
+RSS key update = Y
+RSS reta update = Y
+VLAN filter = Y
+Inline crypto = Y
+Packet type parsing = Y
+Timesync = Y
+Basic stats = Y
+Extended stats = Y
+FW version = Y
+Module EEPROM dump = Y
+Multiprocess aware = Y
Linux = Y
x86-32 = Y
x86-64 = Y
+
+[rte_flow items]
+eth = P
+geneve = Y
+gre = Y
+gtpu = Y
+ipv4 = Y
+ipv6 = Y
+ipv6_frag_ext = Y
+nvgre = Y
+sctp = Y
+tcp = Y
+udp = Y
+vlan = P
+vxlan = Y
+vxlan_gpe = Y
+
+[rte_flow actions]
+count = Y
+drop = Y
+mark = Y
+passthru = Y
+port_representor = Y
+queue = Y
+represented_port = Y
+rss = Y
+send_to_kernel = Y
+port_id = Y
diff --git a/doc/guides/nics/sxe2.rst b/doc/guides/nics/sxe2.rst
index 539072b076..51110629d8 100644
--- a/doc/guides/nics/sxe2.rst
+++ b/doc/guides/nics/sxe2.rst
@@ -35,3 +35,171 @@ preventing unauthorized access to random physical memory.
This capability allows the PMD to coexist with kernel network interfaces
which remain functional, although they stop receiving unicast packets
as long as they share the same MAC address.
+
+Configuration
+-------------
+
+Runtime Configuration
+~~~~~~~~~~~~~~~~~~~~~
+
+- ``Traffic Management Scheduling Levels``
+
+ The DPDK Traffic Management (rte_tm) APIs can be used to configure the Tx scheduler on the NIC.
+ The ``sched-layer-mode`` parameter can be used to set the number of scheduling levels
+ in the transmit scheduling hierarchy.
+ The provided value must be between 0 and 3.
+ If the value provided is greater than the number of levels supported by the HW,
+ the driver will use the hardware maximum value.
+
+- ``flow-duplicate-pattern`` parameter [int]
+
+ There are three options to choose:
+
+ - 0. Prevent insertion of flow rules with the same pattern items.
+ In this case, duplicate rules are rejected and error code EEXIST is returned.
+
+ - 1. Allow duplicate rules with the same pattern items.
+ The last added rule takes effect.
+ If the current active rule is deleted, the second-to-last added rule takes effect, and so on.
+
+ - 2. Allow duplicate rules with the same pattern items.
+ The first added rule takes effect.
+ If the current active rule is deleted, the second added rule takes effect, and so on.
+
+ This option only applies to the switch engine flow type.
+ For the Fnav flow engine type, duplicate rules are always rejected.
+
+ By default, the PMD will set this value to 1 (last added rule takes effect).
+
+
+- ``fnav-stat-type`` parameter [int]
+
+ This parameter controls the Fnav flow engine statistics type used
+ for flow rule hit counting (via ``rte_flow_query``).
+
+ - 1: Only count the number of packets.
+ - 2: Only count the number of bytes.
+ - 3: Count both packets and bytes (default).
+
+ Default value is 3 (count both packets and bytes).
+
+- ``drv-sw-stats`` parameter [int]
+
+ This parameter controls whether per-packet software statistics
+ (SW stats) are collected in the Rx data path.
+
+ Hardware packet statistic counters may be inaccurate for certain
+ packet types due to hardware design limitations.
+ When accuracy of Rx packet classification statistics is critical,
+ enabling this parameter allows the driver to accumulate statistics
+ in software as packets are received, providing an alternative
+ statistical path that bypasses hardware counter inaccuracies.
+
+ - 0: Disable software statistics collection (default).
+ The basic port statistics (``ipackets``, ``ibytes``) are reported
+ from the hardware counters.
+ - 1: Enable software statistics collection.
+ Per-packet software statistics are accumulated for unicast,
+ multicast, broadcast, and dropped packets in the Rx data path.
+
+ When enabled, the following extended statistics (xstats) are available:
+ ``rx_sw_unicast_packets``, ``rx_sw_multicast_packets``,
+ ``rx_sw_broadcast_packets``, ``rx_sw_drop_packets``,
+ and ``rx_sw_drop_bytes``.
+
+- ``no-sched-mode`` parameter [int]
+
+ This parameter enables non-scheduling mode (no-sched mode).
+ When enabled, the transmit path bypasses the hardware scheduling module
+ and packets are sent directly out through the port.
+ This results in lower transmit latency and higher throughput,
+ but Traffic Management (rte_tm) APIs are not supported in this mode.
+
+ - 0: Disable non-scheduling mode (default).
+ The transmit path goes through the hardware scheduling hierarchy.
+ Traffic Management (rte_tm) APIs can be used to configure the Tx scheduler.
+ - 1: Enable non-scheduling mode.
+ The transmit path bypasses the hardware scheduling module.
+ Packets are sent directly from the port at full speed without scheduling.
+ Traffic Management (rte_tm) APIs are not available in this mode.
+
+- ``rx-low-latency`` parameter [int]
+
+ This parameter controls the interrupt throttling (ITR) interval
+ for Rx queue interrupts.
+
+ When enabled, the driver sets a shorter interrupt coalescing timeout
+ (``SXE2_ITR_INTERVAL_LOW``, approximately 1 μs),
+ reducing the time between packet arrival and interrupt delivery to the CPU.
+ This lowers receive latency at the cost of increased CPU interrupt rate.
+
+ When disabled (default), the driver uses the normal interrupt throttling
+ interval (``SXE2_ITR_INTERVAL_NORMAL``, approximately 20 μs),
+ which reduces the CPU interrupt rate at the expense of higher receive latency.
+
+ - 0: Disable Rx low latency (default).
+ Normal interrupt throttling interval (~20 μs) is used.
+ - 1: Enable Rx low latency.
+ Low interrupt throttling interval (~1 μs) is used
+ for reduced receive latency.
+
+- ``function-flow-direct`` parameter [int]
+
+ This parameter controls whether flow rules from different functional units
+ (DPDK vs kernel driver) are isolated or combined when both drivers
+ control the same physical port.
+
+ When the DPDK PMD and the kernel network driver coexist on the same port,
+ flow rules may originate from either driver.
+ This parameter determines how the source VSI (Virtual Switch Interface)
+ of each flow rule is handled during hardware programming.
+
+ - 0 (default): Isolate flow rules between DPDK and kernel.
+ When ``flow_isolated`` is enabled (``rte_flow_isolate()`` called),
+ kernel-side flow rules take priority and DPDK-side flow rules are suppressed.
+ When ``flow_isolated`` is disabled, DPDK-side flow rules take priority
+ and kernel-side flow rules are suppressed.
+ Only one functional unit's flows are active at a time.
+
+ - 1: Allow direct flow rules from both DPDK and kernel simultaneously.
+ Both DPDK and kernel source VSIs are preserved in the hardware flow table.
+ Flow rules from both sides are programmed without isolation.
+
+ This option only applies to FNAV and ACL flow engine types
+ and does not apply to PF bond devices.
+
+Extended Statistics (xstats)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The PMD provides the following extended statistics (xstats) for detailed
+monitoring of receive-side packet classification and software-level accounting.
+The software statistics path is provided as a workaround for hardware
+counter inaccuracies on certain packet types --- it accumulates per-packet
+statistics directly in the Rx data path, ensuring that unicast, multicast,
+broadcast, and drop counts reflect the actual packets processed by the driver.
+
+Receive Software Statistics
+ These counters are collected in the Rx data path when ``drv-sw-stats=1``
+ is configured (see the ``drv-sw-stats`` devarg above).
+ When ``drv-sw-stats`` is disabled (default), these xstats report zero.
+
+ - ``rx_sw_unicast_packets``: Number of unicast packets received.
+ - ``rx_sw_multicast_packets``: Number of multicast packets received.
+ - ``rx_sw_broadcast_packets``: Number of broadcast packets received.
+ - ``rx_sw_drop_packets``: Number of packets dropped in the Rx data path.
+ - ``rx_sw_drop_bytes``: Number of bytes dropped in the Rx data path.
+
+ When ``drv-sw-stats`` is enabled, the basic counters ``ipackets`` and
+ ``ibytes`` (from ``rte_eth_stats``) also reflect the software-accumulated
+ packet and byte counts. Otherwise, they are reported from hardware counters.
+
+Fnav Flow Engine Statistics
+ The Fnav flow engine statistics type is controlled by the ``fnav-stat-type``
+ devarg (see above). Depending on the configuration:
+
+ - ``fnav-stat-type=1``: Only packet count is available.
+ - ``fnav-stat-type=2``: Only byte count is available.
+ - ``fnav-stat-type=3`` (default): Both packet and byte counts are available.
+
+ Flow query results (via ``rte_flow_query``) expose these per-flow counters
+ through the query API, not via xstats.
--
2.52.0
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox