Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Nick Wang <nwang@suse.com>
To: nwang@suse.com
Cc: linux-kernel@vger.kernel.org,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	philipp.reisner@linbit.com, drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [Patch v2 09/10] drbd: Handle zero out command from peer node
Date: Mon, 13 Jul 2015 16:39:03 +0800	[thread overview]
Message-ID: <1436776744-3135-10-git-send-email-nwang@suse.com> (raw)
In-Reply-To: <1436776744-3135-1-git-send-email-nwang@suse.com>

Recevie P_UUID flag 16 for starting zero out device,
P_UUID flag 32 after both side finished zeroing,
Change state to uptodate.

Signed-off-by: Nick Wang <nwang@suse.com>
CC: Philipp Reisner <philipp.reisner@linbit.com>
CC: Lars Ellenberg <lars.ellenberg@linbit.com>
CC: drbd-dev@lists.linbit.com
CC: linux-kernel@vger.kernel.org
---
 drbd/drbd_receiver.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/drbd/drbd_receiver.c b/drbd/drbd_receiver.c
index 6eae84f..4d6d99a 100644
--- a/drbd/drbd_receiver.c
+++ b/drbd/drbd_receiver.c
@@ -4317,6 +4317,15 @@ static int receive_uuids(struct drbd_connection *connection, struct packet_info
 			peer_device->connection->agreed_pro_version >= 90 &&
 			device->ldev->md.uuid[UI_CURRENT] == UUID_JUST_CREATED &&
 			(p_uuid[UI_FLAGS] & 8);
+		int zero_out_devices =
+			device->state.conn == C_CONNECTED &&
+			peer_device->connection->agreed_pro_version >= 90 &&
+			device->ldev->md.uuid[UI_CURRENT] == UUID_JUST_CREATED &&
+			(p_uuid[UI_FLAGS] & 16);
+		int zero_out_finish =
+			device->state.conn == C_CONNECTED &&
+			peer_device->connection->agreed_pro_version >= 90 &&
+			(p_uuid[UI_FLAGS] & 32);
 		if (skip_initial_sync) {
 			drbd_info(device, "Accepted new current UUID, preparing to skip initial sync\n");
 			drbd_bitmap_io(device, &drbd_bmio_clear_n_write,
@@ -4324,11 +4333,35 @@ static int receive_uuids(struct drbd_connection *connection, struct packet_info
 					BM_LOCKED_TEST_ALLOWED);
 			_drbd_uuid_set(device, UI_CURRENT, p_uuid[UI_CURRENT]);
 			_drbd_uuid_set(device, UI_BITMAP, 0);
+			spin_lock_irq(&device->resource->req_lock);
 			_drbd_set_state(_NS2(device, disk, D_UP_TO_DATE, pdsk, D_UP_TO_DATE),
 					CS_VERBOSE, NULL);
+			spin_unlock_irq(&device->resource->req_lock);
 			drbd_md_sync(device);
 			updated_uuids = 1;
 		}
+
+		if (zero_out_devices) {
+			drbd_info(device, "Accepted to zero out devices, will take a long time\n");
+			drbd_bitmap_io(device, &drbd_bmio_clear_n_write,
+					"clear_n_write from receive_uuids",
+					BM_LOCKED_TEST_ALLOWED);
+			_drbd_uuid_set(device, UI_CURRENT, p_uuid[UI_CURRENT]);
+			_drbd_uuid_set(device, UI_BITMAP, 0);
+			drbd_print_uuids(device, "cleared bitmap UUID for zeroing device");
+
+			drbd_device_post_work(device, S_ZERO_START);
+			updated_uuids = 1;
+		}
+
+		if (zero_out_finish) {
+			drbd_info(device, "Both side finished zero out devices.\n");
+			spin_lock_irq(&device->resource->req_lock);
+			_drbd_set_state(_NS2(device, disk, D_UP_TO_DATE, pdsk, D_UP_TO_DATE),
+					CS_VERBOSE, NULL);
+			spin_unlock_irq(&device->resource->req_lock);
+		}
+
 		put_ldev(device);
 	} else if (device->state.disk < D_INCONSISTENT &&
 		   device->state.role == R_PRIMARY) {
-- 
1.8.4.5


  parent reply	other threads:[~2015-07-13  8:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  8:38 [Drbd-dev] [Patch v2 00/10] Zero out devices instead of initial full sync Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 01/10] drbd: Fix the wrong logic of moving history Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid Nick Wang
2015-07-31 12:50   ` Philipp Reisner
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 03/10] drbd: A function to zero out drbd backing device Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 04/10] drbd: New packet P_ZERO_OUT Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 05/10] drbd: Functions to notify peer node to zero out Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 06/10] drbd: Wapper for zeroing out device by worker Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 07/10] drbd: Flags for background drbd device work Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 08/10] drbd: Function to work with packet P_ZERO_OUT Nick Wang
2015-07-13  8:39 ` Nick Wang [this message]
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 10/10] drbd: Handle new-current-uuid --zap-devices Nick Wang
2015-07-31 12:48 ` [Drbd-dev] [Patch v2 00/10] Zero out devices instead of initial full sync Philipp Reisner
2015-08-06 10:04   ` [Drbd-dev] [PATCH v3 0/1] Zeroout/discard " Nick Wang
2015-08-06 10:04     ` [Drbd-dev] [PATCH] drbd: Support zeroout device " Nick Wang
2015-08-18 15:03       ` Lars Ellenberg
2015-08-21  3:26         ` [Drbd-dev] 答复: " Nick Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436776744-3135-10-git-send-email-nwang@suse.com \
    --to=nwang@suse.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox