From: Philipp Reisner <philipp.reisner@linbit.com>
To: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [PATCH 08/19] drbd: fix spurious alert level printk
Date: Tue, 4 Aug 2015 14:56:32 +0200 [thread overview]
Message-ID: <1438693003-17554-9-git-send-email-philipp.reisner@linbit.com> (raw)
In-Reply-To: <1438693003-17554-1-git-send-email-philipp.reisner@linbit.com>
From: Lars Ellenberg <lars.ellenberg@linbit.com>
When accessing out meta data area on disk, we double check the
plausibility of the requested sector offsets, and are very noisy about
it if they look suspicious.
During initial read of our "superblock", for "external" meta data,
this triggered because the range estimate returned by
drbd_md_last_sector() was still wrong.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
---
drivers/block/drbd/drbd_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 30c1120..903d22e 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -3271,6 +3271,10 @@ int drbd_md_read(struct drbd_device *device, struct drbd_backing_dev *bdev)
* and read it. */
bdev->md.meta_dev_idx = bdev->disk_conf->meta_dev_idx;
bdev->md.md_offset = drbd_md_ss(bdev);
+ /* Even for (flexible or indexed) external meta data,
+ * initially restrict us to the 4k superblock for now.
+ * Affects the paranoia out-of-range access check in drbd_md_sync_page_io(). */
+ bdev->md.md_size_sect = 8;
if (drbd_md_sync_page_io(device, bdev, bdev->md.md_offset, READ)) {
/* NOTE: can't do normal error processing here as this is
--
1.9.1
next prev parent reply other threads:[~2015-08-04 12:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 12:56 [Drbd-dev] [PATCH 00/19] RFC DRBD updates for the 4.3 merge window (part II) Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 01/19] drbd: Rename asender to ack_receiver Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 02/19] drbd: Create a dedicated workqueue for sending acks on the control connection Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 03/19] drbd: prevent NULL pointer deref when resuming diskless primary Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 04/19] drbd: debugfs: expose ed_data_gen_id Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 05/19] drbd: use resource name in workqueue Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 06/19] drbd: avoid redefinition of BITS_PER_PAGE Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 07/19] drbd: use bitmap_weight() helper, don't open code Philipp Reisner
2015-08-04 12:56 ` Philipp Reisner [this message]
2015-08-04 12:56 ` [Drbd-dev] [PATCH 09/19] drbd: fix queue limit setup for discard Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 10/19] drbd: make drbd known to lsblk: use bd_link_disk_holder Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 11/19] lru_cache: Converted lc_seq_printf_status to return void Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 12/19] drbd: don't block forever in disconnect during resync if fencing=r-a-stonith Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 13/19] drbd: fix memory leak in drbd_adm_resize Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 14/19] drbd: fix "endless" transfer log walk in protocol A Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 15/19] drbd: make suspend_io() / resume_io() must be thread and recursion safe Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 16/19] drbd: separate out __al_write_transaction helper function Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 17/19] drbd: avoid potential deadlock during handshake Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 18/19] drbd: fix error path during resize Philipp Reisner
2015-08-04 12:56 ` [Drbd-dev] [PATCH 19/19] MAINTAINERS: Updated information for DRBD DRIVER Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438693003-17554-9-git-send-email-philipp.reisner@linbit.com \
--to=philipp.reisner@linbit.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox