From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 8BA32101AC7B for ; Thu, 26 Jul 2018 14:24:35 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id v14-v6so1524697wro.5 for ; Thu, 26 Jul 2018 05:24:35 -0700 (PDT) Received: from soda.linbit (212-186-191-219.static.upcbusiness.at. [212.186.191.219]) by smtp.gmail.com with ESMTPSA id u4-v6sm2397015wrt.31.2018.07.26.05.17.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Jul 2018 05:17:41 -0700 (PDT) Resent-Message-ID: <20180726121740.GZ25507@soda.linbit> Received: from sipsolutions.net (s3.sipsolutions.net [144.76.63.242]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 1E51C1011B9A for ; Wed, 25 Jul 2018 10:02:29 +0200 (CEST) Message-ID: <1532503493.3223.0.camel@sipsolutions.net> From: Johannes Berg To: Kees Cook , Herbert Xu Date: Wed, 25 Jul 2018 09:24:53 +0200 In-Reply-To: <20180724164936.37477-14-keescook@chromium.org> (sfid-20180724_184958_869692_1891A71D) References: <20180724164936.37477-1-keescook@chromium.org> <20180724164936.37477-14-keescook@chromium.org> (sfid-20180724_184958_869692_1891A71D) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: Lars, Giovanni Cabiddu , Ingo, Mike Snitzer , "Gustavo A. R. Silva" , linux-wireless@vger.kernel.org, Will Deacon , x86@kernel.org, linux-kernel@vger.kernel.org, David Howells , dm-devel@redhat.com, Jia-Ju Bai , Paul Mackerras , Pavel Machek , "H. Peter Anvin" , linux-afs@lists.infradead.org, Alasdair Kergon , drbd-dev@lists.linbit.com, devel@driverdev.osuosl.org, Eric Biggers , qat-linux@intel.com, Molnar , Uytterhoeven , Geert, Rabin Vincent , Arnd Bergmann , Tudor-Dan Ambarus , linux-block@vger.kernel.org, Josh Poimboeuf , Thomas Gleixner , Andrew Morton , Jens Axboe , Greg Kroah-Hartman , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Philipp Reisner , linux-crypto@vger.kernel.org, linux-ppp@vger.kernel.org, Ellenberg , Tim Chen , netdev@vger.kernel.org, David Woodhouse Subject: Re: [Drbd-dev] [PATCH v6 13/18] wireless/lib80211: Convert from ahash to shash List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2018-07-24 at 09:49 -0700, Kees Cook wrote: > In preparing to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of > the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash > to direct shash. By removing a layer of indirection this both improves > performance and reduces stack usage. The stack allocation will be made > a fixed size in a later patch to the crypto subsystem. > I think you sent this before - it should be in net-next now. johannes