From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 401A94203AB for ; Wed, 3 May 2023 17:39:51 +0200 (CEST) Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-33110a36153so693555ab.0 for ; Wed, 03 May 2023 08:39:51 -0700 (PDT) From: Jens Axboe To: =?utf-8?q?Christoph_B=C3=B6hmwalder?= In-Reply-To: <20230503121937.17232-1-christoph.boehmwalder@linbit.com> References: <20230503121937.17232-1-christoph.boehmwalder@linbit.com> Message-Id: <168312838868.941317.975898202413701616.b4-ty@kernel.dk> Date: Wed, 03 May 2023 09:39:48 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: Christoph Hellwig , Thomas Voegtle , Philipp Reisner , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Lars Ellenberg , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH] drbd: correctly submit flush bio on barrier List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 03 May 2023 14:19:37 +0200, Christoph Böhmwalder wrote: > When we receive a flush command (or "barrier" in DRBD), we currently use > a REQ_OP_FLUSH with the REQ_PREFLUSH flag set. > > The correct way to submit a flush bio is by using a REQ_OP_WRITE without > any data, and set the REQ_PREFLUSH flag. > > Since commit b4a6bb3a67aa ("block: add a sanity check for non-write > flush/fua bios"), this triggers a warning in the block layer, but this > has been broken for quite some time before that. > > [...] Applied, thanks! [1/1] drbd: correctly submit flush bio on barrier commit: 3899d94e3831ee07ea6821c032dc297aec80586a Best regards, -- Jens Axboe