From: Jens Axboe <axboe@kernel.dk>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: David Howells <dhowells@redhat.com>,
Serguei Ivantsov <manowar@gsc-game.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org,
Linux regression tracking <regressions@leemhuis.info>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: swap bvec_set_page len and offset
Date: Wed, 06 Sep 2023 07:33:18 -0600 [thread overview]
Message-ID: <169400719806.700937.1715411703006180940.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230906133034.948817-1-christoph.boehmwalder@linbit.com>
On Wed, 06 Sep 2023 15:30:34 +0200, Christoph Böhmwalder wrote:
> bvec_set_page has the following signature:
>
> static inline void bvec_set_page(struct bio_vec *bv, struct page *page,
> unsigned int len, unsigned int offset)
>
> However, the usage in DRBD swaps the len and offset parameters. This
> leads to a bvec with length=0 instead of the intended length=4096, which
> causes sock_sendmsg to return -EIO.
>
> [...]
Applied, thanks!
[1/1] drbd: swap bvec_set_page len and offset
commit: 4b9c2edaf7282d60e069551b4b28abc2932cd3e3
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-09-06 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 13:30 [Drbd-dev] [PATCH] drbd: swap bvec_set_page len and offset Christoph Böhmwalder
2023-09-06 13:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169400719806.700937.1715411703006180940.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=dhowells@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manowar@gsc-game.com \
--cc=philipp.reisner@linbit.com \
--cc=regressions@leemhuis.info \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox